Optimizations#226
Closed
GeorgCantor wants to merge 4 commits intoGradleUp:mainfrom
Closed
Conversation
Member
|
I'm sorry but given the size of the datasets and this running in a much more complex process (Gradle), the gain is probably negligible. From a cursory look, the code looks correct but I just don't think the change is worth it. I can change my mind if you can share real life numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made:
Single-pass processing - Replaced multiple collection operations with a single iteration over input files
Set-based deduplication - Used linkedSetOf() instead of distinct() for O(1) uniqueness checking
Before:
Created intermediate collection gavs
3 separate map operations + 3 distinct() calls
Total complexity: ~O(6n) operations
After:
Processes each file once during iteration
Immediate deduplication via Set insertion
Total complexity: O(n) with better constant factors
Lower memory usage (no intermediate collection)
Result: More efficient code with better memory and time performance characteristics, especially for large input sets.