Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.1.0
6.5.0
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ src/go/proto/
.clwb/
.ijwb/
.idea/
.vscode/

# C++ coverage
generated/
Expand Down
4 changes: 2 additions & 2 deletions DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ For example: ***gcr.io/cloudesf-testing/gcpproxy-prow:v20240727-v2.46.0-27-g6c21
Run the following command by replacing the **latest_image_link** with the link found above.

```
docker run -ti --privileged -v /var/run/docker.sock:/var/run/docker.sock -v ~/esp-v2:/esp-v2 ${latest_image_link} /bin/bash
docker run -ti -v /var/run/docker.sock:/var/run/docker.sock -v ~/esp-v2:/esp-v2 ${latest_image_link} /bin/bash
```

#### Change Directory to `esp-v2`
Expand Down Expand Up @@ -191,7 +191,7 @@ make test-envoy
To run integration tests:

```
make integration-test-run-parallel
make integration-test
```

#### Enable IDE Integration
Expand Down
5 changes: 3 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# 3) Check if envoy_build_config/extensions_build_config.bzl is up-to-date.
# Try to match it with the one in source/extensions and comment out unneeded extensions.

ENVOY_SHA1 = "349011c2ebd40f070510e34f4605bff1da64fb0e" # v1.30.7
ENVOY_SHA256 = "fee4d8c1005cac9a241e29d51a903b1b369515a8a77e5b7fe320520ae7c7b855"
ENVOY_SHA1 = "63c6a8f4f1e12389ffd94f1ace83cd714ac8e9c3" # v1.30.11

ENVOY_SHA256 = "20e4dd8049aef9e89b8dbba721686d3ee7e56a983e8767416b648f0ea63ff4d9"

http_archive(
name = "envoy",
Expand Down
5 changes: 3 additions & 2 deletions src/api_proxy/service_control/request_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,9 @@ Status set_credential_id(const SupportedLabel& l, const ReportRequestInfo& info,
if (info.check_response_info.error.is_network_error) {
(*labels)[l.name] = absl::StrCat(kApiKeyPrefix, "UNKNOWN");
} else {
(*labels)[l.name] = info.check_response_info.api_key_uid.empty() ? absl::StrCat(kApiKeyPrefix, info.api_key)
: info.check_response_info.api_key_uid;
(*labels)[l.name] = info.check_response_info.api_key_uid.empty()
? absl::StrCat(kApiKeyPrefix, info.api_key)
: info.check_response_info.api_key_uid;
}
} else {
(*labels)[l.name] = absl::StrCat(kApiKeyPrefix, info.api_key);
Expand Down
3 changes: 1 addition & 2 deletions src/api_proxy/service_control/request_builder_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ TEST_F(RequestBuilderTest, ReportApiKeyVerifiedWithApiKeyUIDUnknownTest) {
info.check_response_info.api_key_uid = "fake_api_key_uid";
info.enable_api_key_uid_reporting = true;
info.check_response_info.error = {"UNREACHABLE", true,
ScResponseErrorType::CONSUMER_QUOTA};
ScResponseErrorType::CONSUMER_QUOTA};

gasv1::ReportRequest request;
ASSERT_TRUE(scp_.FillReportRequest(info, &request).ok());
Expand Down Expand Up @@ -506,7 +506,6 @@ TEST_F(RequestBuilderTest, ReportApiKeyVerifiedNotReportApiKeyUIDTest) {
ASSERT_EQ(fields.at("api_key").string_value(), "api_key_x");
}


TEST_F(RequestBuilderTest, ReportApiKeyNotVerifiedTest) {
ReportRequestInfo info;
FillOperationInfo(&info);
Expand Down
2 changes: 1 addition & 1 deletion src/envoy/http/service_control/filter_fuzz_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ DEFINE_PROTO_FUZZER(
stream_info->route_ = mock_route;
EXPECT_CALL(*mock_route, mostSpecificPerFilterConfig(kFilterName))
.WillRepeatedly(
Invoke([per_route](const std::string&)
Invoke([per_route](std::string_view)
-> const Envoy::Router::RouteSpecificFilterConfig* {
return per_route.get();
}));
Expand Down
2 changes: 1 addition & 1 deletion src/envoy/token/token_subscriber.cc
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void TokenSubscriber::refresh() {
return;
}

const struct Envoy::Http::AsyncClient::RequestOptions options =
const Envoy::Http::AsyncClient::RequestOptions options =
Envoy::Http::AsyncClient::RequestOptions()
.setTimeout(std::chrono::duration_cast<std::chrono::milliseconds>(
fetch_timeout_))
Expand Down
Binary file modified tests/endpoints/grpc_echo/proto/api_descriptor.pb
Binary file not shown.