Skip to content

guard long cast of numeric jwt claim in extractJwtPayload #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netliomax25-code wants to merge 1 commit into
base: master
Choose a base branch
from
Open

guard long cast of numeric jwt claim in extractJwtPayload #1016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/envoy/http/service_control/handler_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#include "src/envoy/http/service_control/handler_utils.h"

#include <cmath>
#include <limits>
#include <sstream>
#include <vector>

Expand Down Expand Up @@ -114,11 +116,23 @@ void extractJwtPayload(const Envoy::ProtobufWkt::Value& value,
case ::google::protobuf::Value::kNullValue:
absl::StrAppend(&info_jwt_payloads, jwt_payload_path, "=;");
return;
case ::google::protobuf::Value::kNumberValue:
absl::StrAppend(&info_jwt_payloads, jwt_payload_path, "=",
std::to_string(static_cast<long>(value.number_value())),
";");
case ::google::protobuf::Value::kNumberValue: {
// The JWT number claim is parsed into a double. Casting to long is
// undefined when it is non-finite or outside long's range, so guard the
// narrowing (same as JsonStruct::getInteger) and render the raw value in
// that case.
const double number = value.number_value();
if (std::isfinite(number) &&
number >= static_cast<double>(std::numeric_limits<long>::min()) &&
number < 9223372036854775808.0 /* 2^63 */) {
absl::StrAppend(&info_jwt_payloads, jwt_payload_path, "=",
std::to_string(static_cast<long>(number)), ";");
} else {
absl::StrAppend(&info_jwt_payloads, jwt_payload_path, "=",
absl::StrCat(number), ";");
}
return;
}
case ::google::protobuf::Value::kBoolValue:
absl::StrAppend(&info_jwt_payloads, jwt_payload_path, "=",
value.bool_value() ? "true" : "false", ";");
Expand Down