Conversation
| @@ -36,6 +36,9 @@ jobs: | |||
| github.event_name != 'schedule' || | |||
There was a problem hiding this comment.
what's the goal here? this job is a cron for nightly publishing but we disabled it awhile ago. for actual releases we don't use GHA
There was a problem hiding this comment.
goal is to follow https://docs.npmjs.com/trusted-publishers. i think Paul already linked the GitHub publish.yml in npm to this repo. so it's a matter of linking it up on the GitHub side of things.
There was a problem hiding this comment.
yeah, let's actually rename this file to publish-nightly.yml
And then we'll want to create a brand new file for publish. That is a combination of this file and whatever my skill thinks we should do.
There was a problem hiding this comment.
oh i see you introduced a new release.yml.
yahhhhh if you're okay with it.. renaming this old file to publish-nightly and keeping the new one as publish.yml is slightly better.
There was a problem hiding this comment.
yea that's fine. renaming it. including build-all bc it was in manual instructions...overkill?
There was a problem hiding this comment.
no in fact that's probably required for this to work. probably? dunno.
|
alright, I think I figured out the config now..hopefully. did a dry run, results here |
set up npm Trusted Publishing (OIDC) for the repository.
previous nightly
publish.yml->publish_nightly.ymlpublish.ymlwill now run when a tag is pushed or with a manual trigger. this will still require manual tag push as part of the release process, it's just replacing the npm publish step.also had to run
npm pkg fixbecause it was complaining about the binary paths.fyi, generated with help of paul's npm-trusted-publishing skill