Skip to content

misc: set up npm trusted publishing#16944

Open
lusayaa wants to merge 18 commits intomainfrom
npm-trusted-publishing
Open

misc: set up npm trusted publishing#16944
lusayaa wants to merge 18 commits intomainfrom
npm-trusted-publishing

Conversation

@lusayaa
Copy link
Copy Markdown
Collaborator

@lusayaa lusayaa commented Apr 2, 2026

set up npm Trusted Publishing (OIDC) for the repository.

previous nightly publish.yml -> publish_nightly.yml
publish.ymlwill now run when a tag is pushed or with a manual trigger. this will still require manual tag push as part of the release process, it's just replacing the npm publish step.

also had to run npm pkg fix because it was complaining about the binary paths.

fyi, generated with help of paul's npm-trusted-publishing skill

@lusayaa lusayaa changed the title chore: set up npm trusted publishing misc: set up npm trusted publishing Apr 2, 2026
Comment thread .github/workflows/publish.yml Outdated
@@ -36,6 +36,9 @@ jobs:
github.event_name != 'schedule' ||
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the goal here? this job is a cron for nightly publishing but we disabled it awhile ago. for actual releases we don't use GHA

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goal is to follow https://docs.npmjs.com/trusted-publishers. i think Paul already linked the GitHub publish.yml in npm to this repo. so it's a matter of linking it up on the GitHub side of things.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's actually rename this file to publish-nightly.yml

And then we'll want to create a brand new file for publish. That is a combination of this file and whatever my skill thinks we should do.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see you introduced a new release.yml.

yahhhhh if you're okay with it.. renaming this old file to publish-nightly and keeping the new one as publish.yml is slightly better.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea that's fine. renaming it. including build-all bc it was in manual instructions...overkill?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no in fact that's probably required for this to work. probably? dunno.

Comment thread .github/workflows/release.yml Fixed
Comment thread .github/workflows/publish-nightly.yml Fixed
Comment thread .github/workflows/publish-nightly.yml Fixed
@lusayaa
Copy link
Copy Markdown
Collaborator Author

lusayaa commented Apr 3, 2026

alright, I think I figured out the config now..hopefully. did a dry run, results here

@lusayaa lusayaa marked this pull request as ready for review April 3, 2026 14:05
@lusayaa lusayaa requested a review from a team as a code owner April 3, 2026 14:05
@lusayaa lusayaa requested review from connorjclark and removed request for a team April 3, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants