fix(citizen-claim-widget): keep claim toast visible through on-chain confirmation by goodbounties-nanoclaw-agent[bot] · Pull Request #168 · GoodDollar/GoodWidget

goodbounties-nanoclaw-agent · 2026-08-17T07:03:39Z

Summary

Toast for a chain's claim used to stay on "sign transaction in your wallet" copy forever, even after the wallet had already signed and broadcast the tx — reported by @hadar Rottenberg (screenshot showed 3 stacked signing toasts for Celo/Fuse/XDC).
Rather than dismissing the toast at signing time (which would hide the still-pending on-chain confirmation), the toast now updates its copy/color the moment the tx is signed+broadcast, and only actually resolves/dismisses once the claim is confirmed on-chain.
No @goodsdks/citizen-sdk change required — GoodWidget already owns the raw wallet provider it hands to viem's custom() transport in adapter.ts, so it can observe the eth_sendTransaction call resolving directly.

Changes

adapter.ts: provider-proxy helper (wrapProviderWithSubmissionSignal) detects the wallet's eth_sendTransaction resolving; threaded as an optional onTransactionSubmitted callback through claim / claimOnChain / claimAll.
CitizenClaimWidget.tsx: on that signal, updates each chain's toast to "Claiming on <chain> — waiting for blockchain confirmation" with a confirming status, staying persistent (duration: 0) until the claim promise settles.
Toast.tsx: adds a confirming ToastStatus with a subtly deeper blue border ($primaryDark vs $primary for signing) so it reads as related-but-distinct from the initial signing toast, and stays clearly different from the green success state.

Scope note

Only the default non-custodial (wallet-provider-driven) claim path is covered — the one in the bug report. Custodial execution mode (claimExecution.clientsByChain) supplies pre-built clients from outside GoodWidget, so we don't control that provider and can't intercept it the same way; flagging as a possible separate follow-up if that path is ever in scope.

Test plan

pnpm --filter @goodwidget/ui --filter @goodwidget/citizen-claim-widget --filter @goodwidget/superfluid-campaign-widget --filter @goodwidget/embed build — clean
pnpm --filter @goodwidget/ui --filter @goodwidget/citizen-claim-widget --filter @goodwidget/superfluid-campaign-widget --filter @goodwidget/embed lint — clean (only pre-existing warnings unrelated to this change)
Manual: connect wallet, claim on a chain, confirm toast updates from "sign transaction" -> "waiting for blockchain confirmation" -> "succeeded", never disappearing early

🤖 Generated with Claude Code

Copilot

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

This PR adds a mid-flight “confirming” state for claim transactions and propagates a callback that fires after wallet submission (broadcast) but before on-chain confirmation, enabling UX toasts to transition from “sign in wallet” to “waiting for confirmation”.

Changes:

Added confirming toast status with styling and icon behavior.
Extended claim adapter action APIs to accept an onTransactionSubmitted callback.
Implemented an EIP-1193 provider proxy to detect eth_sendTransaction completion and trigger the callback, then updated the widget to use the new confirming toast state.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
packages/ui/src/components/Toast.tsx	Adds `confirming` toast status and maps it to styling + spinner icon behavior.
packages/citizen-claim-widget/src/widgetRuntimeContract.ts	Extends adapter action contract with optional `onTransactionSubmitted` callbacks.
packages/citizen-claim-widget/src/adapter.ts	Proxies EIP-1193 provider to emit a submission signal and threads callback through claim flows.
packages/citizen-claim-widget/src/CitizenClaimWidget.tsx	Uses `onTransactionSubmitted` to update toast status/message to `confirming`.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

sirpy · 2026-08-17T08:27:15Z

@copilot

claim widget tests are failing. useEffect is unknown is the error we get.
add running playwright tests to the github actions
modify github actions so superfluid widget and ai widget are only deployed if their code has changed

Copilot · 2026-08-17T08:40:00Z

@copilot

claim widget tests are failing. useEffect is unknown is the error we get.

add running playwright tests to the github actions
...

Addressed in 6668551: fixed the missing useEffect import in the citizen-claim Storybook helper, added a GitHub Actions workflow to run the root Playwright demo suite, and narrowed the AI credits / Superfluid deploy workflows so they only trigger when their own app/widget code changes.

sirpy · 2026-08-17T08:56:11Z

@copilot

restore the deploy paths for ai credits and superfluid under push to branch main (the section for pull requests changes are fine)
undo the wrapping of the provider with a proxy and instead create a PR to modify the claim sdk in the repo GoodDollar/GoodSDKs to receive an optional callback

Copilot · 2026-08-17T08:56:19Z

@sirpy I've opened a new pull request, #169, to work on those changes. Once the pull request is ready, I'll request review from you.

sirpy · 2026-08-17T10:10:10Z

@copilot

restore the deploy paths for ai credits and superfluid under push to branch main (the section for pull requests changes are fine)
undo the wrapping of the provider with a proxy.
in the GoodDollar/GoodSDKs repo create a new PR to modify the claim sdk package to receive an optional callback (currently there's an onTxhash callback, which is not fully configured and used correctly in that claim sdk)
fix the toast issue based on the upcomming changes you did to the goodsdks package

Copilot · 2026-08-17T10:10:18Z

@sirpy I've opened a new pull request, #171, to work on those changes. Once the pull request is ready, I'll request review from you.

sirpy · 2026-08-19T09:30:06Z

@copilot
in the GoodDollar/GoodSDKs repo create a new Issue with request and instruciton to modify the claim sdk package to receive an optional callback (currently there's an onTxhash callback, which is not fully configured and used correctly in that claim sdk)

Copilot · 2026-08-19T09:46:22Z

@copilot
in the GoodDollar/GoodSDKs repo create a new Issue with request and instruciton to modify the claim sdk package to receive an optional callback (currently there's an onTxhash callback, whic...

Opened GoodDollar/GoodSDKs#62.

…rough on-chain confirmation Previously the "sign transaction in your wallet" toast for a chain's claim never updated after the wallet finished signing, so with a switch to manual sign-per-chain it looked stuck/duplicated across chains. - adapter.ts: wrap the wallet provider so an optional callback fires the instant eth_sendTransaction resolves (signed + broadcast), threaded through claim/claimOnChain/claimAll. No citizen-sdk change needed since GoodWidget already owns the provider handed to viem's custom() transport. - CitizenClaimWidget.tsx: on that signal, update each chain's toast copy to "waiting for blockchain confirmation" and keep it persistent until the claim promise actually settles (success/error), instead of leaving stale "sign in your wallet" copy visible. - Toast.tsx: add a 'confirming' status with a subtly deeper blue border ($primaryDark vs $primary) to distinguish "signing" from "awaiting confirmation" without resembling the success (green) state. Co-Authored-By: Claude <noreply@anthropic.com> On-Behalf-Of: gdpatchagent[onecli] (yaskkeryodtdijpv)

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

…confirmation (#171) * Initial plan * fix(workflows, adapter): restore deploy paths and remove provider proxy 1. Restore push-path triggers for ai-credits-web and superfluid-campaign-web workflows (the pull_request_target section remains narrowed as-is). 2. Remove the wrapProviderWithSubmissionSignal provider proxy from adapter.ts. 3. Thread onTransactionSubmitted directly into sdk.claimSDK.claim() as the second argument (ClaimSDK.submitAndWait already accepts an onHash callback; a companion PR to GoodDollar/GoodSDKs will expose it from claim()). Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

…ation cap to 10s The `not_whitelisted` Playwright test was making live calls to forno.celo.org without any request mocking, which caused intermittent CI failures when the endpoint was unreachable or slow. - Intercept forno.celo.org requests via page.route in the not_whitelisted test - Return zero address (0x000...000) for getWhitelistedRoot (selector 0x2d0e9b46), which the ClaimSDK interprets as "not whitelisted" - Return empty result (0x) for all other calls (daily-stats, claimables are best-effort and caught internally in the adapter) - Reduce waitForText timeout from 40s to 15s since mock responds immediately - Raise claimAll duration upper bound from 6,500ms to 10,000ms to give CI headroom over the @goodsdks/citizen-sdk hardcoded 5-second delay Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

goodbounties-nanoclaw-agent Bot requested review from a team and blueogin and a lite review from Copilot August 17, 2026 07:03

goodbounties-nanoclaw-agent Bot deployed to internal August 17, 2026 07:03 Active

goodbounties-nanoclaw-agent Bot deployed to preview August 17, 2026 07:03 View deployment

Copilot AI reviewed Aug 17, 2026

View reviewed changes

Comment thread packages/citizen-claim-widget/src/adapter.ts Outdated

Comment thread packages/citizen-claim-widget/src/widgetRuntimeContract.ts Outdated

Copilot started work on behalf of sirpy August 17, 2026 08:27 View session

Copilot finished work on behalf of sirpy August 17, 2026 08:40

Copilot AI requested a review from sirpy August 17, 2026 08:40

Copilot AI mentioned this pull request Aug 17, 2026

chore: add Playwright CI workflow, fix storybook import, and update deploy workflow triggers #169

Closed

3 tasks

Copilot AI mentioned this pull request Aug 17, 2026

fix(citizen-claim-widget): keep claim toast visible through on-chain confirmation #171

Merged

3 tasks

sirpy deployed to internal August 19, 2026 09:24 — with GitHub Actions Active

sirpy had a problem deploying to preview August 19, 2026 09:24 — with GitHub Actions Failure

Copilot started work on behalf of sirpy August 19, 2026 09:29 View session

Copilot finished work on behalf of sirpy August 19, 2026 09:42

Copilot started work on behalf of sirpy August 19, 2026 09:42 View session

Copilot finished work on behalf of sirpy August 19, 2026 09:48

goodbounties-nanoclaw-agent Bot and others added 4 commits August 20, 2026 09:59

fix tests and workflow triggers

62febbd

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

fix(citizen-claim-widget): unify claim callback signatures

39e1245

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

sirpy force-pushed the fix/citizen-claim-toast-confirmation branch from 624a5ab to 39e1245 Compare August 20, 2026 06:59

sirpy deployed to internal August 20, 2026 06:59 — with GitHub Actions Active

sirpy deployed to preview August 20, 2026 06:59 — with GitHub Actions View deployment

sirpy approved these changes Aug 20, 2026

View reviewed changes

Copilot started work on behalf of sirpy August 20, 2026 09:09 View session

Copilot finished work on behalf of sirpy August 20, 2026 09:54

Copilot AI requested a review from sirpy August 20, 2026 09:54

Navigation Menu

Uh oh!

fix(citizen-claim-widget): keep claim toast visible through on-chain confirmation - #168

fix(citizen-claim-widget): keep claim toast visible through on-chain confirmation#168
goodbounties-nanoclaw-agent[bot] wants to merge 5 commits into
mainfrom
fix/citizen-claim-toast-confirmation

goodbounties-nanoclaw-agent Bot commented Aug 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sirpy commented Aug 17, 2026

Uh oh!

Copilot AI commented Aug 17, 2026

Uh oh!

sirpy commented Aug 17, 2026

Uh oh!

Copilot AI commented Aug 17, 2026

Uh oh!

sirpy commented Aug 17, 2026

Uh oh!

Copilot AI commented Aug 17, 2026

Uh oh!

sirpy commented Aug 19, 2026

Uh oh!

Copilot AI commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

goodbounties-nanoclaw-agent Bot commented Aug 17, 2026

Summary

Changes

Scope note

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

sirpy commented Aug 17, 2026

Uh oh!

Copilot AI commented Aug 17, 2026

Uh oh!

sirpy commented Aug 17, 2026

Uh oh!

Copilot AI commented Aug 17, 2026

Uh oh!

sirpy commented Aug 17, 2026

Uh oh!

Copilot AI commented Aug 17, 2026

Uh oh!

sirpy commented Aug 19, 2026

Uh oh!

Copilot AI commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants