Skip to content

Draft: feat: add a skill command#1188

Draft
GG-HH wants to merge 1 commit intomainfrom
hhubert/-/add_skill
Draft

Draft: feat: add a skill command#1188
GG-HH wants to merge 1 commit intomainfrom
hhubert/-/add_skill

Conversation

@GG-HH
Copy link
Copy Markdown
Member

@GG-HH GG-HH commented Mar 6, 2026

This command allow one to add a default skill through ggshield

Context

What has been done

Validation

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

This command allow one to add a default skill through ggshield
@GG-HH GG-HH requested a review from a team as a code owner March 6, 2026 15:16
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 97.40260% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.66%. Comparing base (6b08b22) to head (fb5f1df).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
ggshield/cmd/skill/uninstall.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   92.61%   92.66%   +0.04%     
==========================================
  Files         160      165       +5     
  Lines        7731     7808      +77     
==========================================
+ Hits         7160     7235      +75     
- Misses        571      573       +2     
Flag Coverage Δ
unittests 92.66% <97.40%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulpetit-gg-ext
Copy link
Copy Markdown
Contributor

paulpetit-gg-ext commented Mar 9, 2026

(I know this is still marked as draft ^^)

Since we are planning to add other AI-related commands like MCP configuration discovery, I wonder if we should create a more general ai vertical?

Same, the hook to prevent secrets from being sent to LLMs (#1183) is currently under ggshield install and ggshield secret scan ai-hook but maybe we could move it under this new vertical.

Otherwise, other idea: have this command under ggshield install instead. 🙃

What do you think?

@GG-HH
Copy link
Copy Markdown
Member Author

GG-HH commented Mar 9, 2026

That's actually a good remark, I agree that we should not go in all directions and it can probably be a sub-element of ggshield install group. I would not use a generic 'ai' path because i believe we will add AI interactions in almost all commands at some point (I would differentiate: how ggshield secures your AI workloads and how can you use ggshield with AI).
TBH, this MR is not meant to be merged, I wanted it to support a few discussions and I am very happy to get your comment!

@sevbch sevbch marked this pull request as draft March 10, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants