Skip to content

fix(build): fix missing type argument handling for non-generic typed lists (e.g. Uint8List) #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KiddoV wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(build): fix missing type argument handling for non-generic typed lists (e.g. Uint8List) #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions packages/brick_build/lib/src/utils/shared_checker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,18 @@ class SharedChecker<_SiblingModel extends Model> {
/// the same domain or provider (e.g. `SqliteModel`).
SharedChecker(this.targetType);

/// Retrieves type argument, i.e. `Type` in `Future<Type>` or `List<Type>`
DartType get argType => (targetType as InterfaceType).typeArguments.first;
/// Gets `T` from `List<T>` / `Future<T>`, or fallback for typed lists
DartType get argType {
final type = targetType as InterfaceType;
if (type.typeArguments.isNotEmpty) {
return type.typeArguments.first;
}
// Fallback for typed data lists
if (isList || isIterable) {
return type.element.library.typeProvider.intType;
}
throw StateError('No type argument for $targetType');
}

///
Type get asPrimitive {
Expand Down Expand Up @@ -125,9 +135,9 @@ class SharedChecker<_SiblingModel extends Model> {

///
bool get isIterable =>
_iterableChecker.isExactlyType(targetType) ||
_listChecker.isExactlyType(targetType) ||
_setChecker.isExactlyType(targetType);
_iterableChecker.isAssignableFromType(targetType) ||
_listChecker.isAssignableFromType(targetType) ||
_setChecker.isAssignableFromType(targetType);

///
bool get isList => _listChecker.isExactlyType(targetType);
Expand Down
Loading