Remove dead JobSystem-guarded code and fix the README performance images - #68
Merged
duburcqa merged 1 commit intoJul 23, 2026
Merged
Conversation
The JobSystem was already removed, but inert code guarded by '#if 0' and '#ifdef MADRONA_USE_JOB_SYSTEM' (never defined) still referenced the deleted JobID/JobManager types across context.inl, custom_context.inl, context.cpp, worker_init.hpp and the device context.inl -- delete it. Also drop the unused image_util.cpp (STB_IMAGE_WRITE with no callers). The earlier subsystem strip removed scripts/perf_benchmark/, which the README's Performance section linked for its FPS images and documented in a benchmark subsection. Restore the two comparison images under docs/ and repoint them, and drop the now-dangling benchmark subsection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead code
The JobSystem was already removed, but inert code guarded by
#if 0and#ifdef MADRONA_USE_JOB_SYSTEM(a macro that is never defined anywhere) still referenced the deletedJobID/JobManagertypes. Removed those blocks from:include/madrona/context.inl(two blocks),include/madrona/custom_context.inl,src/mw/device/include/madrona/context.inlsrc/core/context.cpp,src/core/worker_init.hpp(All verified: the macro is never defined, no
#else/live branch inside any removed block, live class layout comes from the untouchedMADRONA_USE_TASK_GRAPHguards.)Also dropped
src/render/image_util.cpp— a loneSTB_IMAGE_WRITE_IMPLEMENTATIONunit with nostbi_writecallers anywhere.README
The earlier subsystem strip (#66) removed
scripts/perf_benchmark/, which the README's Performance section linked for its two FPS images and documented in a benchmark subsection. Restored the two comparison images underdocs/and repointed them; removed the now-dangling benchmark subsection.Validation
Cluster (RTX): fresh build + full 38 batch-render tests (
test_batch_render/test_offscreen/test_camera) — 38 passed.