Skip to content

Fix double-close of the CUDA-imported external-memory fd #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duburcqa merged 1 commit into from
Jul 23, 2026
Merged

Fix double-close of the CUDA-imported external-memory fd #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/render/vk/cuda_interop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,12 @@ CudaImportedBuffer::~CudaImportedBuffer()

cudaFree(dev_ptr_);
cudaDestroyExternalMemory(ext_mem_);
close(ext_fd_);
// Do NOT close(ext_fd_): cudaImportExternalMemory() with an OpaqueFd handle
// transfers ownership of the fd to the CUDA driver (per the CUDA docs, any
// operation on it afterwards is undefined behavior). Closing it here is a
// double-close -- the driver closes the same fd during teardown, and once its
// number has been recycled by an unrelated open() this corrupts that file,
// surfacing as spurious "Bad file descriptor" errors elsewhere in the process.
}

}
Loading