v2.6: Backport GOCART1 ifx fixes - #468
Open
mathomp4 wants to merge 1 commit into
Open
Conversation
mathomp4
added
the
0 diff
mathomp4
marked this pull request as ready for review
August 5, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #399 into GOCART v2.6. The fixes are already on v2.7 (aka
develop) but v2.7 is still in testing. With this PR, ifx will be able to run GOCART v2.6 which current GEOSgcm v11.10+ uses.When running GEOSgcm v12 with ifx 2025.3 and OPS emissions in Release mode, the CO_GridComp (and other legacy GOCART GridComps) would fail during initialization due to ifx's stricter enforcement of intent(in) on arguments that are temporarily modified internally.
See #399 for more details.
Tested and for ifort it is zero-diff for both AMIP and OPS. For ifx, it runs both, which is good.