Remove unused xuartps.h include from Xilinx UltraScale and Zynq network interfaces#1343
Open
ismailemrecntz wants to merge 2 commits into
Open
Remove unused xuartps.h include from Xilinx UltraScale and Zynq network interfaces#1343ismailemrecntz wants to merge 2 commits into
ismailemrecntz wants to merge 2 commits into
Conversation
aggarg
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the unused
#include "xuartps.h"from the Xilinx Zynq and UltraScale network interface headers.When the PS UART peripheral is not enabled in the hardware design, the Xilinx BSP does not generate
xuartps.h. This causes FreeRTOS+TCP projects using these ports to fail compilation even though the Ethernet network interface does not appear to use anyXUartPssymbols directly.Removing this include avoids an unnecessary dependency on the PS UART driver for hardware designs where PS UART is disabled.
This was discussed on the FreeRTOS community forum:
https://forums.freertos.org/t/freertos-tcp-ultrascale-port-requires-xuartps-h/24996
Changes
#include "xuartps.h"from the Zynq network interface.#include "xuartps.h"from the UltraScale network interface.Testing
XUartPssymbols are used by these network interface headers.