Skip to content

Add totalPages and currentPage to ref imperative handle #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TSMMark wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Add totalPages and currentPage to ref imperative handle #1103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/nuka/src/Carousel/Carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,12 @@ export const Carousel = forwardRef<SlideHandle, CarouselProps>(
});

// -- forward events to ref
useImperativeHandle(ref, () => ({ goForward, goBack, goToPage }), [
useImperativeHandle(ref, () => ({ goForward, goBack, goToPage, totalPages, currentPage }), [
goForward,
goBack,
goToPage,
totalPages,
currentPage
]);
Comment on lines +124 to 130
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useImperativeHandle is typed with forwardRef<SlideHandle, ...>, but SlideHandle (in packages/nuka/src/types.ts) currently only includes goForward/goBack/goToPage. Returning an object literal with totalPages and currentPage will fail TypeScript excess-property checking here. Please extend SlideHandle to include these new numeric fields (and ensure the public type export is updated accordingly).

Copilot uses AI. Check for mistakes.

// -- autoplay
Expand Down