Skip to content

Upgrade OSS Badges package, fix badge rendering issue#1083

Open
bryantkelley wants to merge 3 commits intomainfrom
task/update-oss-badges
Open

Upgrade OSS Badges package, fix badge rendering issue#1083
bryantkelley wants to merge 3 commits intomainfrom
task/update-oss-badges

Conversation

@bryantkelley
Copy link
Copy Markdown

@bryantkelley bryantkelley commented Nov 20, 2024

Description

  • Upgrades OSS Badges packages
  • Fixes an issue with the featured project badges section

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran website locally and featured projects badges no longer span the entire column

Checklist

  • My code follows the style guidelines of this project (I have run pnpm run lint)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have recorded any user-facing fixes or changes with pnpm changeset.
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bryantkelley bryantkelley self-assigned this Nov 20, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nuka-carousel-website Error Error Apr 7, 2026 11:05pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 2b7bd05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sarmeyer sarmeyer requested review from Copilot and removed request for carbonrobot April 7, 2026 21:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the website’s OSS badge usage to align with a newer formidable-oss-badges release and resolves a layout issue in the “featured projects” badge grid.

Changes:

  • Upgraded formidable-oss-badges to ^1.6.0.
  • Replaced generic FeaturedBadge usage with specific badge components (e.g., NukaBadge, SpectacleBadge, etc.).
  • Moved featured project badge configuration into LandingFeaturedProjects and adjusted badge sizing classes.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
website/src/pages/index.tsx Removes inline featured projects data now handled by the component.
website/src/components/landing/landing-hero.tsx Switches hero badge rendering to NukaBadge.
website/src/components/landing/landing-featured-projects.tsx Uses specific badge components and updates badge rendering/sizing for the grid.
website/package.json Bumps formidable-oss-badges version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants