PhotoOutput now has public 'avCapturePhotoOutput',#12
Open
drewster99 wants to merge 5 commits intoFluidGroup:mainfrom
Open
PhotoOutput now has public 'avCapturePhotoOutput',#12drewster99 wants to merge 5 commits intoFluidGroup:mainfrom
drewster99 wants to merge 5 commits intoFluidGroup:mainfrom
Conversation
…nably configure your settings during capture without information like `isShutterSoundSuppressionSupported`.
- PixelBufferView: Use @mainactor Task with explicit capture to avoid sending parameter data race warning on pixelBuffer handler - PhotoTools: Mark completion handler @sendable to satisfy strict concurrency checking for cross-isolation capture
CoreImageFilter is constructed once and passed to an actor-isolated context. Adding @unchecked Sendable satisfies the generic Sendable constraint on AnyCVPixelBufferOutput without requiring CIFilter to be Sendable.
Use weak self captures instead of unowned self in Task and addHandler closures to satisfy strict concurrency sending requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
avCapturePhotoOutputtoPhotoOutputso you can more reasonably configure your settings during capture, including information likeisShutterSoundSuppressionSupported.Added public access to AVCapturePhotoOutput. Why?
My app wanted to set the option in AVCaptureSettings of
isShutterSoundSuppressionEnabledtotrue, but this resulted in a crash for some users with the error:I didn't rename anything, but just added this extra public,