Skip to content

fix(Segment membership PoC): Identity backfill broken due to lack of JSON column support #7584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
khvn26 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −44
Draft

fix(Segment membership PoC): Identity backfill broken due to lack of JSON column support #7584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ dependencies = [
"flagsmith-flag-engine>=10.1.0,<11.0.0",
"flagsmith-sql-flag-engine>=0.1.0,<0.2.0",
"django-clickhouse-backend>=1.4,<2.0",
"clickhouse-driver",
"boto3>=1.35.95,<1.36.0",
"slack-sdk>=3.9.0,<3.10.0",
"asgiref>=3.8.1,<3.9.0",
Expand Down Expand Up @@ -181,6 +182,7 @@ flagsmith-ldap = { git = "https://github.com/flagsmith/flagsmith-ldap", tag = "v
workflows-logic = { git = "https://github.com/flagsmith/flagsmith-workflows", tag = "v3.4.0" }
licensing = { git = "https://github.com/flagsmith/licensing", tag = "v0.3.0" }
flagsmith-private = { index = "flagsmith-pypi-production" }
clickhouse-driver = { git = "https://github.com/Flagsmith/clickhouse-driver", branch = "newjson" }

[tool.uv]
required-version = "0.11.14" # Ensure this matches the version in .pre-commit-config.yaml
Expand Down
47 changes: 3 additions & 44 deletions api/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions infrastructure/aws/staging/ecs-task-definition-migration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
{
"name": "ANALYTICS_DATABASE_URL",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-heAdoB:ANALYTICS_DATABASE_URL::"
},
{
"name": "CLICKHOUSE_URL",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:clickhouse-url-ns26gC"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The valueFrom ARN for CLICKHOUSE_URL is inconsistent with the ANALYTICS_DATABASE_URL configuration and likely incorrect. While ANALYTICS_DATABASE_URL references a specific key within the shared ECS-API-heAdoB secret, this entry points to a different secret (clickhouse-url-ns26gC) and lacks the required :KEY:: syntax for JSON secrets. If clickhouse-url-ns26gC is a standard Key/Value secret, ECS will inject the entire JSON object as a string, causing the application to fail. Given the PR description states this should use the same value as admin-api, it should likely reference the same secret and key as ANALYTICS_DATABASE_URL.

Suggested change
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:clickhouse-url-ns26gC"
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-heAdoB:ANALYTICS_DATABASE_URL::"

Copy link
Copy Markdown
Member Author

@khvn26 khvn26 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

}
],
"logConfiguration": {
Expand Down
Loading