-
Notifications
You must be signed in to change notification settings - Fork 1
[FEATURE] 전화번호 중복가입 차단 및 로그인 플로우 개선 #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeonbinggu
wants to merge
10
commits into
develop
Choose a base branch
from
block-duplicate-sns-signup(#346)
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
20eecdd
feat: 로그인 페이지 최근 로그인 소셜 안내 말풍선 표시(#346)
jeonbinggu 055d0a7
refactor: 전화번호 중복(MEMBER_412)에 따른 중복가입 차단(#346)
jeonbinggu e53d1df
fix: 에러 코드(MEMBER_412) 유실 방지(#346)
jeonbinggu 7151fb9
feat: 하드웨어 뒤로가기 시 앱 종료 확인 다이얼로그 추가 및 히스토리 스택 버그 수정(#346)
jeonbinggu d878b86
refactor: 말풍선 위치 조정(#346)
jeonbinggu 54a9339
refactor: 버튼 gap 조정(#346)
jeonbinggu b8f096f
Merge branch 'develop' of https://github.com/Finders-Official/Web int…
jeonbinggu 2405d68
fix: 가입 미완료 상태에서 최근 로그인 SNS가 기록되는 문제 수정(#346)
jeonbinggu 5db36c0
fix:안드로이드 하드웨어 뒤로가기 동작 개선(#346)
jeonbinggu 2a6aab0
chore: google-services.json을 gitignore에 추가(#346)
jeonbinggu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { PolygonIcon } from "@/assets/icon"; | ||
|
|
||
| interface RecentLoginDialogProps { | ||
| className?: string; | ||
| } | ||
|
|
||
| export function RecentLoginDialog({ className = "" }: RecentLoginDialogProps) { | ||
| return ( | ||
| <div className={`flex flex-col items-center self-center ${className}`}> | ||
| <div className="bg-neutral-0 rounded-lg px-2 py-1.25 text-xs font-semibold text-orange-500"> | ||
| 최근에 로그인 했어요 | ||
| </div> | ||
| <PolygonIcon className="-mt-0.5 h-2.5 w-2.5" /> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // 서버 ErrorCode: 인증번호 발송 시 이미 가입된 전화번호 | ||
| export const PHONE_ALREADY_REGISTERED_CODE = "MEMBER_412"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import type { SocialProvider } from "@/types/auth"; | ||
|
|
||
| const RECENT_LOGIN_PROVIDER_KEY = "finders:recentLoginProvider"; | ||
|
|
||
| // 로그아웃과 무관하게 남아야 해서 useAuthStore(persist)와 분리된 별도 키로 관리 | ||
| export function setRecentLoginProvider(provider: SocialProvider) { | ||
| try { | ||
| localStorage.setItem(RECENT_LOGIN_PROVIDER_KEY, provider); | ||
| } catch (e) { | ||
| console.error("최근 로그인 정보 저장에 실패했습니다.", e); | ||
| } | ||
| } | ||
|
|
||
| export function getRecentLoginProvider(): SocialProvider | null { | ||
| try { | ||
| const value = localStorage.getItem(RECENT_LOGIN_PROVIDER_KEY); | ||
| return value === "KAKAO" || value === "APPLE" ? value : null; | ||
| } catch { | ||
| return null; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Major]
pointer-events-none이 없어 이 말풍선이 Apple 버튼의 탭 영역을 가립니다.말풍선은
AppleButton과 같은relative컨테이너 안에position: absolute로, DOM상 버튼 뒤에 렌더됩니다. 버튼(Press→<button>)은 static이라 페인팅 순서상 말풍선이 위에 오고, 히트 테스트도 말풍선이 먼저 받습니다.겹침 계산: 말풍선 높이 34px(
text-xs16 +py-1.2510 + Polygonh-2.510 −-mt-0.52), 컨테이너 높이 =AppleButton의h-[3.125rem]50px.bottom-0→ top 16px, 여기에translate-y-1/4(자기 높이의 25% = 8.5px) → top 24.5px. 즉 **y 24.5~50px, 버튼 높이의 51%**가 덮입니다. 가로로는left-1/2 -translate-x-1/2로 중앙 약 130px — "Apple로 계속하기" 라벨이 있는 지점입니다.재현: iOS 앱 또는 모바일 웹에서
finders:recentLoginProvider가"KAKAO"인 상태 → 로그인 화면 → Apple 버튼 중앙 아래쪽 탭 →SignInWithApple.authorize()가 호출되지 않습니다. 버튼 좌우 끝이나 위쪽만 반응합니다.정적 외형은 그대로 두고 히트 테스트만 통과시키면 됩니다.
Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기획에 의해 의도한 것임.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그 버튼이 가려지는 건 그럴 수 있는데 터치가 막히는 것도 의도된건가요?