Skip to content

[FIX] 배송지 addressId 타입 number→string (#342) - #343

Open
IISweetHeartII wants to merge 1 commit into
developfrom
fix/address-id-tsid-#342
Open

[FIX] 배송지 addressId 타입 number→string (#342)#343
IISweetHeartII wants to merge 1 commit into
developfrom
fix/address-id-tsid-#342

Conversation

@IISweetHeartII

Copy link
Copy Markdown
Contributor

🔀 Pull Request Title

[FIX] 배송지 addressId 타입 number→string (#342)

🎞️ 주요 코드 설명

Address.addressId number → string

BE GET/POST /users/addresses 응답의 addressId@Tsid Long이라 TSID 문자열(예: "0QX09V7ZKXHC6")로 내려옵니다. FE 타입만 number로 선언되어 있어 계약 드리프트 상태였고, Number() 변환이 추가되는 순간 2^53 초과 정밀도 손실(NaN/반올림) 버그가 되는 구조라 string으로 통일했습니다. (신고/문의 어드민 NaN 사고와 동일 계열 — TSID 전수조사에서 발견)

연쇄 타입 정리

  • useAddressIdStore.selectedAddressId: number|null → string|null
  • SelectAddressPage LocationState.selectedAddressId: number → string

📌 PR 설명

이번 PR에서 어떤 작업을 했는지 요약해주세요.

  • 배송지 도메인의 addressId 타입을 BE TSID 계약에 맞게 string으로 수정 (런타임 동작 변화 없음 — 기존에도 문자열이 흘렀고 비교는 string===string)
  • pnpm build(tsc -b + vite) 통과 확인

📷 스크린샷

타입 수정만 있어 UI 변화 없음

Closes #342

- BE MemberAddressResponse.addressId는 @tsid(TSID 문자열)인데 FE가 number로 선언
- Address 타입, useAddressIdStore, SelectAddressPage LocationState를 string으로 통일
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finders Ready Ready Preview, Comment Jul 10, 2026 6:57am

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the type of address identifiers from number to string across the application. Specifically, it modifies the Address type definition, the useAddressIdStore Zustand store, and the SelectAddressPage location state to use string instead of number for address IDs. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 배송지 addressId 타입 number→string (BE TSID 계약 불일치)

1 participant