fix: bracket padding#740
Open
acsandmann wants to merge 3 commits intoFelixKratz:masterfrom
Open
Conversation
FelixKratz
reviewed
Jul 19, 2025
| int left_edge = group->first_window->origin.x - bracket->background.padding_left; | ||
| int right_edge = group->last_window->origin.x | ||
| + group->last_window->frame.size.width | ||
| + bracket->background.padding_right; |
Owner
There was a problem hiding this comment.
I am not sure that this actually does what would be expected behavior of the background padding. The background padding is a padding applied around the background, i.e. in the bracket case this would be an additional padding around the bracket. From what I see the implementation here simply applies an additional padding inside the bracket.
However, there is a problem with having "actual" bracket paddings (see #351 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr simply applies the background padding to a bracket as i saw no reason for it not to already be doing this
not sure what the formatting standard is for this project so i can def fix that since i don't think it matches