Take bitrate into account#9
Open
MagicLike wants to merge 3 commits intoFarisHijazi:masterfrom
Open
Conversation
The original bitrate gets detected and applied onto the output file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I used the tool for the first time I noticed the bitrate got absolutely obliterated, so I tried my best to hack a solution together which detects the original bitrate and applies it onto the output file. For this I chose h264 with a crf value of 18 and aac audio encoding for the best quality-size-compatability compromise.
Please check this thoroughly before merging (or just don't merge), as I don't have a big knowledge of python nor ffmpeg and I only did some minor testing with a few files, but I think this is a good-ish approach.
Obviously triggers/options for the encoder to be used and if audio should also be cut would be even better, but for now I think this would be a great addition.