Skip to content

Fix bug where last segment of video is dropped #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adenalhardan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug where last segment of video is dropped #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions deblack/deblack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,16 @@ def get_blackdetect(inpath, invert=False):
times = [float(x.split("=")[1].strip()) for x in delete_back2back(lines) if x]
assert len(times), "no black detected"

# Handle video ending with black by adding "duration" as last trim if needed
video_length_cmd = ["ffprobe", "-i", inpath, "-show_entries", "format=duration", "-of", "csv=p=0", "-v", "quiet"]
video_length_str = subprocess.check_output(video_length_cmd).decode("utf-8")
video_length = float(video_length_str)

if len(times) % 2 != 0:
video_length_cmd = ["ffprobe", "-i", inpath, "-show_entries", "format=duration", "-of", "csv=p=0", "-v", "quiet"]
video_length_str = subprocess.check_output(video_length_cmd).decode("utf-8")
video_length = float(video_length_str)
# If video ends in black, add end of video as last trim endpoint
times.append(video_length)
else:
# Otherwise, add a zero-length trim at the end of the video to ensure last non-black segment is kept
times.extend([video_length, video_length])

if not invert:
times = [0] + times[:-1]
Expand Down