Skip to content

chore: Consolidate classes to use IXplatRegister system - #1212

Merged
Robotgiggle merged 25 commits into
FallingColors:1.21from
Olfi01:issue/1065-refactor-xplat-register
Jul 27, 2026
Merged

chore: Consolidate classes to use IXplatRegister system#1212
Robotgiggle merged 25 commits into
FallingColors:1.21from
Olfi01:issue/1065-refactor-xplat-register

Conversation

@Olfi01

@Olfi01 Olfi01 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Closes #1065

As mentioned in that issue, a consistent way of registering things across the mod is desirable. With the IXplatRegister system, this can be achieved (as this PR does).

@github-project-automation github-project-automation Bot moved this to 📋 Backlog in Hex Casting Jul 26, 2026
@Olfi01
Olfi01 marked this pull request as draft July 26, 2026 21:17
@Olfi01
Olfi01 marked this pull request as ready for review July 26, 2026 23:31
@Olfi01

Olfi01 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

No idea why the Fabric registries were lazily initialized when Forge registries are not, and Fabric is usually the eager one of the two anyway.

@Olfi01

Olfi01 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

This will also fix #1179, since the repeated event from Freecam will not cause an error any more.

@Robotgiggle Robotgiggle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robotgiggle
Robotgiggle added this pull request to the merge queue Jul 27, 2026
Merged via the queue into FallingColors:1.21 with commit 54c6e37 Jul 27, 2026
7 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from 📋 Backlog to ✅ Done in Hex Casting Jul 27, 2026
@Olfi01
Olfi01 deleted the issue/1065-refactor-xplat-register branch July 27, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants