Properly register media holder component on fabric - #1164
Merged
Conversation
s5bug
reviewed
Jun 15, 2026
| } | ||
| } | ||
|
|
||
| HexCardinalComponents.MEDIA_HOLDER_LOOKUP.registerForItems({ |
Contributor
There was a problem hiding this comment.
Do any of these need to be de-duplicated?
Member
Author
There was a problem hiding this comment.
No, all of that is still necessary. The code I added is for handling items with their own classes that implement MediaHolderItem. All the items in that section don't have their own classes (they're just basic Item instances) so they can't extend MediaHolderItem and the media holder has to be registered manually.
s5bug
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1162 by adding registration code for MediaHolderItem in the relevant part of FabricHexInitializer.
As a side note, I think much of the fabric-side item component stuff should be renamed now that it uses vanilla components rather than Cardinal Components, but that's out of scope for this PR (see #1165 for more).