Skip to content

feat: GRAPH.EFFECT command + effects replication#383

Merged
AviAvni merged 1 commit intomainfrom
effects-replication
Apr 14, 2026
Merged

feat: GRAPH.EFFECT command + effects replication#383
AviAvni merged 1 commit intomainfrom
effects-replication

Conversation

@AviAvni
Copy link
Copy Markdown
Contributor

@AviAvni AviAvni commented Apr 14, 2026

Summary

  • Add GRAPH.EFFECT command: replays binary effects buffer on replica (create nodes/edges, update attrs, schema changes, index operations)
  • Add replicate_effects(), should_use_effects(), build_index_effects() to graph_core.rs
  • Update WriteQueryResult to carry effects buffer for replication
  • Register effect module in commands/mod.rs

Command not yet registered in lib.rs — that happens in the final wiring PR.

Part of splitting #359 into smaller reviewable PRs.

Test plan

  • cargo check passes
  • Full integration tested in follow-up PR when wired into lib.rs

- Add effect.rs: GRAPH.EFFECT command replays binary effects buffer on replica
  (create nodes/edges, update attrs, schema changes, index ops)
- Add graph_core.rs: replicate_effects(), should_use_effects(),
  build_index_effects(), WriteQueryResult with effects buffer
- Register effect module in commands/mod.rs
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@AviAvni has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 54 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 54 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 967f3bd9-2f54-4569-a4cd-731e8a5917c2

📥 Commits

Reviewing files that changed from the base of the PR and between fb5ec4a and 47cfa22.

📒 Files selected for processing (3)
  • src/commands/effect.rs
  • src/commands/mod.rs
  • src/graph_core.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch effects-replication

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AviAvni AviAvni merged commit 4d5a2b4 into main Apr 14, 2026
13 of 14 checks passed
@AviAvni AviAvni deleted the effects-replication branch April 14, 2026 14:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 30.19943% with 245 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.96%. Comparing base (7c72209) to head (47cfa22).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/effect.rs 0.00% 231 Missing ⚠️
src/graph_core.rs 88.33% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   82.32%   81.96%   -0.37%     
==========================================
  Files         110      111       +1     
  Lines       30078    30424     +346     
==========================================
+ Hits        24762    24937     +175     
- Misses       5316     5487     +171     
Flag Coverage Δ
fuzz 40.81% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant