Skip to content

feat: add Encode/Decode<19> for Value type#375

Merged
AviAvni merged 1 commit intomainfrom
value-encode-decode
Apr 14, 2026
Merged

feat: add Encode/Decode<19> for Value type#375
AviAvni merged 1 commit intomainfrom
value-encode-decode

Conversation

@AviAvni
Copy link
Copy Markdown
Contributor

@AviAvni AviAvni commented Apr 14, 2026

Summary

Split from #359.

  • Implement Encode<19> for Value — serialize all property value types to RDB v19 binary format
  • Implement Decode<19> for Value — deserialize from RDB v19 binary format
  • Supports: Bool, Int, Float, String (including interned), List, Point, VecF32, Datetime, Date, Time, Duration, Null

Test plan

  • cargo check passes
  • Used by encoder/decoder in subsequent PRs

Implement RDB v19 serialization for all Value variants including
Bool, Int, Float, String, List, Point, VecF32, and temporal types.

Split from #359.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@AviAvni has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 25 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 25 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eeb7bf98-67d3-45d6-99e1-b558f3f270bc

📥 Commits

Reviewing files that changed from the base of the PR and between d51f96e and 1a368bb.

📒 Files selected for processing (1)
  • graph/src/runtime/value.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch value-encode-decode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 0% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.83%. Comparing base (d51f96e) to head (1a368bb).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
graph/src/runtime/value.rs 0.00% 113 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   84.15%   83.83%   -0.33%     
==========================================
  Files         110      110              
  Lines       28963    29076     +113     
==========================================
+ Hits        24375    24377       +2     
- Misses       4588     4699     +111     
Flag Coverage Δ
fuzz 41.72% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AviAvni AviAvni merged commit 553c6ba into main Apr 14, 2026
14 of 16 checks passed
@AviAvni AviAvni deleted the value-encode-decode branch April 14, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant