Skip to content

feat: make EFFECTS_THRESHOLD runtime-configurable #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AviAvni merged 1 commit into from
Apr 14, 2026
Merged

feat: make EFFECTS_THRESHOLD runtime-configurable #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/commands/config_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@
//! Runtime-settable (via SET):
//! TIMEOUT, TIMEOUT_DEFAULT, TIMEOUT_MAX, RESULTSET_SIZE,
//! MAX_QUEUED_QUERIES, QUERY_MEM_CAPACITY, DELTA_MAX_PENDING_CHANGES,
//! VKEY_MAX_ENTITY_COUNT, JS_HEAP_SIZE, JS_STACK_SIZE
//! VKEY_MAX_ENTITY_COUNT, JS_HEAP_SIZE, JS_STACK_SIZE, EFFECTS_THRESHOLD
//!
//! Read-only (SET returns an error):
//! THREAD_COUNT, OMP_THREAD_COUNT, CACHE_SIZE, ASYNC_DELETE,
//! NODE_CREATION_BUFFER, CMD_INFO, MAX_INFO_QUERIES,
//! EFFECTS_THRESHOLD, BOLT_PORT, DELAY_INDEXING,
//! IMPORT_FOLDER, TEMP_FOLDER
//! BOLT_PORT, DELAY_INDEXING, IMPORT_FOLDER, TEMP_FOLDER
//!
//! ## Multi-SET semantics
//! When multiple name-value pairs are provided in a single SET, all pairs are
Expand Down Expand Up @@ -99,7 +98,8 @@ fn validate_config_set(
| "TIMEOUT_DEFAULT"
| "TIMEOUT_MAX"
| "QUERY_MEM_CAPACITY"
| "DELTA_MAX_PENDING_CHANGES" => {
| "DELTA_MAX_PENDING_CHANGES"
| "EFFECTS_THRESHOLD" => {
let v: i64 = value
.parse()
.map_err(|_| format!("Failed to set config value {name} to {value}"))?;
Expand Down Expand Up @@ -149,7 +149,6 @@ fn validate_config_set(
| "NODE_CREATION_BUFFER"
| "CMD_INFO"
| "MAX_INFO_QUERIES"
| "EFFECTS_THRESHOLD"
| "BOLT_PORT"
| "DELAY_INDEXING"
| "IMPORT_FOLDER"
Expand Down Expand Up @@ -181,6 +180,7 @@ fn apply_config_set(
"DELTA_MAX_PENDING_CHANGES" => {
DELTA_MAX_PENDING_CHANGES.store(val.as_i64(), Ordering::Relaxed);
}
"EFFECTS_THRESHOLD" => EFFECTS_THRESHOLD.store(val.as_i64(), Ordering::Relaxed),
"VKEY_MAX_ENTITY_COUNT" => {
*CONFIGURATION_VKEY_MAX_ENTITY_COUNT.lock(ctx) = val.as_i64();
}
Expand Down
2 changes: 1 addition & 1 deletion src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ pub static TIMEOUT_MAX: AtomicI64 = AtomicI64::new(0);
pub static RESULTSET_SIZE: AtomicI64 = AtomicI64::new(-1);
pub static QUERY_MEM_CAPACITY: AtomicI64 = AtomicI64::new(0);
pub static DELTA_MAX_PENDING_CHANGES: AtomicI64 = AtomicI64::new(10000);
pub static EFFECTS_THRESHOLD: AtomicI64 = AtomicI64::new(300);

// ── Read-only runtime configs ──

pub static OMP_THREAD_COUNT: AtomicI64 = AtomicI64::new(0);
pub static ASYNC_DELETE: AtomicI64 = AtomicI64::new(0);
pub static MAX_INFO_QUERIES: AtomicI64 = AtomicI64::new(1000);
pub static EFFECTS_THRESHOLD: AtomicI64 = AtomicI64::new(300);
pub static BOLT_PORT: AtomicI64 = AtomicI64::new(65535);

pub fn get_thread_count(ctx: &redis_module::Context) -> i64 {
Expand Down
Loading