Repository navigation
TD-831: Add tooltips to favorite buttons - #1674
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The favorite-button tooltip changes have no active review issues.
No open issues 🎉
What changed in this PR
Adds state-dependent tooltips to the shared favorite button, covering overview cards and view/edit pages for all three entity types.
Changes:
- Shows “Als Favorit markieren” or “Favorit entfernen” based on favorite state.
- Uses a constant accessible label while retaining
aria-pressedto communicate state. - Replaces the unused
common.favoritetranslation with add/remove labels.
| File | Description |
|---|---|
apps/chat-bot/src/components/common/favorite-button.tsx |
Adds the tooltip and updates the accessible label. |
apps/chat-bot/messages/de.json |
Replaces the generic favorite label with German add/remove text. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Playwright Smart ReporterPassed: 39 of 39 tests passed.
Baseline run: Slowest tests
|
brueckb
marked this pull request as ready for review
November 12, 2026 09:32
brueckb
requested review from
AsamMax,
TobiasWallura-xitaso,
recursive-hub,
rlaerm and
stschaller-xitaso
as code owners
November 12, 2026 09:32
TobiasWallura-xitaso
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tooltip to the favorite heart button. The text depends on the state: "Als Favorit markieren" or "Favorit entfernen". The tooltip applies to the cards in the overview and to the view and edit pages of all three entity types.
The
aria-labelstays constant ("Als Favorit markieren"), becausearia-pressedalready announces the state. The unusedcommon.favoritekey is removed.🤖 Written by AI under human supervision.