Pin the plugins release that reports why imaging failed - #1227
Merged
Conversation
v1.6.11 carries FOGProject/fog-plugins#21, which was merged the morning after v1.6.10 was cut and so has never reached a server. That change matters more than its own PR made it sound, because the FOS reporting work landed in between. #1206/#1211/#1217/#1223 give a failed task a stored, multi-line report of what FOS actually said, and TaskError sends the flattened opening of it as HOST_IMAGE_FAIL's Reason -- but every bundled listener on v1.6.10 ignores that key and pushes the fixed string "This host has failed to image". Confirmed live before cutting the release. A report whose stored row read fog.download: failed to restore partition 2 partclone.ntfs: /dev/sda2 is busy ERROR: win11-split part 2 checksum mismatch exit code 1 (fog.download) pushed, in its entirety: "fos-deploy-test Failed" / "This host has failed to image". So the whole point of storing the trace stopped at the server. One line, because the sha256 is fetched from the release alongside the tarball rather than pinned here; bin/fetch-plugins.sh reads this constant and verifies what it downloads against it. Verified end to end on this pin: "Fetching plugins v1.6.11" -> "Plugins at v1.6.11", and all three imagefail listeners in the fetched tree read Reason. The 1.5 line keeps its plugins in-tree and has no pin, so its equivalent is a code change: #1226. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.6.11carries FOGProject/fog-plugins#21, which merged the morning afterv1.6.10was cut and so has never reached a server.That change matters more than its own PR made it sound, because the FOS reporting work landed in between. #1206 / #1211 / #1217 / #1223 give a failed task a stored, multi-line report of what FOS actually said, and
TaskErrorsends the flattened opening of it asHOST_IMAGE_FAIL'sReason— but every bundled listener onv1.6.10ignores that key.Found while doing the end-to-end live test of the FOS report path. A report whose stored row read
pushed, in its entirety:
fos-deploy-test Failed/This host has failed to image. So the whole point of storing the trace — somebody seeing it — stopped at the server.Why it is one line of code and eleven files
The sha256 is fetched from the release alongside the tarball rather than pinned here, so
bin/fetch-plugins.shneeds nothing but the constant. The other ten files are the pre-commit hook'sxgettextpass:v1.6.11's listeners introduce new strings (Deploy Complete,Capture Complete,Imaging Failed,an unnamed image,no reason was reported), and the pin bump is exactly the moment those become part of what FOG ships, so the catalog picking them up is correct rather than incidental.Verified end to end on this pin
Checksum verified by the script, and all three
imagefaillisteners in the fetched tree readReason.The 1.5 line
dev-branchkeeps its plugins in-tree and has no pin, so its equivalent is a code change rather than a version bump: #1226 (merged).ntfyhas no listener there, so that one is two files rather than three.🤖 Generated with Claude Code
https://claude.ai/code/session_013mJVe4CpK3rRbi9H5GubXd