Skip to content

Pin the plugins release that reports why imaging failed - #1227

Merged
mastacontrola merged 1 commit into
working-1.6from
plugins-pin-1611
Aug 19, 2026
Merged

Pin the plugins release that reports why imaging failed#1227
mastacontrola merged 1 commit into
working-1.6from
plugins-pin-1611

Conversation

@mastacontrola

Copy link
Copy Markdown
Member

v1.6.11 carries FOGProject/fog-plugins#21, which merged the morning after v1.6.10 was cut and so has never reached a server.

That change matters more than its own PR made it sound, because the FOS reporting work landed in between. #1206 / #1211 / #1217 / #1223 give a failed task a stored, multi-line report of what FOS actually said, and TaskError sends the flattened opening of it as HOST_IMAGE_FAIL's Reason — but every bundled listener on v1.6.10 ignores that key.

Found while doing the end-to-end live test of the FOS report path. A report whose stored row read

fog.download: failed to restore partition 2
  partclone.ntfs: /dev/sda2 is busy
  ERROR: win11-split part 2 checksum mismatch
  exit code 1 (fog.download)

pushed, in its entirety: fos-deploy-test Failed / This host has failed to image. So the whole point of storing the trace — somebody seeing it — stopped at the server.

Why it is one line of code and eleven files

The sha256 is fetched from the release alongside the tarball rather than pinned here, so bin/fetch-plugins.sh needs nothing but the constant. The other ten files are the pre-commit hook's xgettext pass: v1.6.11's listeners introduce new strings (Deploy Complete, Capture Complete, Imaging Failed, an unnamed image, no reason was reported), and the pin bump is exactly the moment those become part of what FOG ships, so the catalog picking them up is correct rather than incidental.

Verified end to end on this pin

$ bash bin/fetch-plugins.sh --version
v1.6.11
$ bash bin/fetch-plugins.sh
Fetching plugins v1.6.11
Plugins at v1.6.11

Checksum verified by the script, and all three imagefail listeners in the fetched tree read Reason.

The 1.5 line

dev-branch keeps its plugins in-tree and has no pin, so its equivalent is a code change rather than a version bump: #1226 (merged). ntfy has no listener there, so that one is two files rather than three.

🤖 Generated with Claude Code

https://claude.ai/code/session_013mJVe4CpK3rRbi9H5GubXd

v1.6.11 carries FOGProject/fog-plugins#21, which was merged the morning after
v1.6.10 was cut and so has never reached a server.

That change matters more than its own PR made it sound, because the FOS
reporting work landed in between. #1206/#1211/#1217/#1223 give a failed task a
stored, multi-line report of what FOS actually said, and TaskError sends the
flattened opening of it as HOST_IMAGE_FAIL's Reason -- but every bundled
listener on v1.6.10 ignores that key and pushes the fixed string "This host
has failed to image".

Confirmed live before cutting the release. A report whose stored row read

    fog.download: failed to restore partition 2
      partclone.ntfs: /dev/sda2 is busy
      ERROR: win11-split part 2 checksum mismatch
      exit code 1 (fog.download)

pushed, in its entirety: "fos-deploy-test Failed" / "This host has failed to
image". So the whole point of storing the trace stopped at the server.

One line, because the sha256 is fetched from the release alongside the
tarball rather than pinned here; bin/fetch-plugins.sh reads this constant and
verifies what it downloads against it. Verified end to end on this pin:
"Fetching plugins v1.6.11" -> "Plugins at v1.6.11", and all three imagefail
listeners in the fetched tree read Reason.

The 1.5 line keeps its plugins in-tree and has no pin, so its equivalent is a
code change: #1226.

Co-Authored-By: Claude <noreply@anthropic.com>
@mastacontrola
mastacontrola merged commit 5e6f601 into working-1.6 Aug 19, 2026
3 checks passed
@mastacontrola
mastacontrola deleted the plugins-pin-1611 branch August 19, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants