Skip to content

Remove RPATH fiddling #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhale wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Open

Remove RPATH fiddling #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,14 @@ target_compile_definitions(
target_compile_definitions(_basixcpp PRIVATE MDSPAN_USE_PAREN_OPERATOR=1)
target_compile_definitions(_basixcpp PRIVATE MDSPAN_USE_BRACKET_OPERATOR=0)

# Add relative rpath so _basixcpp can find the Basix::basix library
# Add relative rpath so _basixcpp can find the bundled Basix::basix library
# when the build is relocated
if(BASIX_FULL_SKBUILD)
if(APPLE)
set_target_properties(_basixcpp PROPERTIES INSTALL_RPATH "@loader_path/lib")
elseif(UNIX)
set_target_properties(_basixcpp PROPERTIES INSTALL_RPATH "$ORIGIN/lib")
endif()
else()
get_target_property(_location Basix::basix LOCATION)
get_filename_component(_basix_dir ${_location} DIRECTORY)
set_target_properties(_basixcpp PROPERTIES INSTALL_RPATH ${_basix_dir})
endif()

# and the nanobind typing stubs.
Expand Down
Loading