Skip to content

Hide Payer row during incomplete bank account setup #90538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelvinBot wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Hide Payer row during incomplete bank account setup #90538

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa9450d
Hide Payer row when bank account setup is incomplete
MelvinBot May 13, 2026
ab3ebb2
Use reimbursementChoice === REIMBURSEMENT_YES instead of isBankAccoun…
MelvinBot May 13, 2026
570f30f
Gate Payer row on reimbursementChoice === REIMBURSEMENT_YES
MelvinBot May 13, 2026
72f5ac3
Add unit tests for Payer row visibility on WorkspaceWorkflowsPage
MelvinBot May 13, 2026
8de16ac
Fix typecheck errors in WorkspaceWorkflowsPayerRowTest
MelvinBot May 13, 2026
8641865
Fix ESLint errors in WorkspaceWorkflowsPayerRowTest
MelvinBot May 13, 2026
ed119e8
Use negated reimbursementChoice check for Payer visibility
MelvinBot May 14, 2026
1442a66
Remove redundant reimbursementChoice !== REIMBURSEMENT_NO check
MelvinBot May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ function WorkspaceWorkflowsPage({policy, route}: WorkspaceWorkflowsPageProps) {
brickRoadIndicator={hasReimburserError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
/>
)}
{shouldShowBankAccount && (
{shouldShowBankAccount && policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_YES && (
Copy link
Copy Markdown
Contributor

@mkhutornyi mkhutornyi May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot add unit test

Copy link
Copy Markdown
Contributor

@nkuoch nkuoch May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot I think some policies might just not have a reimbursementChoice set, but still have a bank account. If that's the case, we should probably still show payer row. So, instead, maybe we should show if reimbursementChoice NOT IN (manual, no)?

<OfflineWithFeedback
pendingAction={policy?.pendingFields?.reimburser}
shouldDisableOpacity={isOffline && !!policy?.pendingFields?.reimbursementChoice && !!policy?.pendingFields?.reimburser}
Expand Down
Loading