Skip to content

fix(a11y): update picker-select fork, remove Android TalkBack workaround #85244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inimaga merged 10 commits into from
Mar 31, 2026
Merged

fix(a11y): update picker-select fork, remove Android TalkBack workaround #85244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
587a08e
fix(a11y): update picker-select fork, remove Android TalkBack workaro…
TaduJR Mar 13, 2026
2dbade7
fix: regenerate lockfile to resolve picker-select fork to acf8e54
TaduJR Mar 13, 2026
247a56b
Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…
TaduJR Mar 13, 2026
90fbbea
Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…
TaduJR Mar 17, 2026
3716dc6
Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…
TaduJR Mar 18, 2026
a2dd375
refactor: remove redundant picker a11y props handled by fork
TaduJR Mar 18, 2026
22b9262
Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…
TaduJR Mar 23, 2026
ab390d1
fix(a11y): pass localized doneText to picker for VoiceOver
TaduJR Mar 23, 2026
669adce
Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…
TaduJR Mar 27, 2026
901f5c4
fix: bump picker-select fork with iOS VoiceOver and touch fixes
TaduJR Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
"react-native-pager-view": "8.0.0",
"react-native-pdf": "7.0.2",
"react-native-permissions": "^5.4.0",
"react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#07d60d78d4772d47afd7a744940fc6b6d1881806",
"react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#acf8e54",
"react-native-plaid-link-sdk": "12.5.3",
"react-native-qrcode-svg": "6.3.21",
"react-native-reanimated": "4.2.1",
Expand Down
7 changes: 0 additions & 7 deletions src/components/Picker/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,17 +209,10 @@ function BasePicker<TPickerValue>({
onClose={disableHighlight}
textInputProps={{
allowFontScaling: false,
importantForAccessibility: 'no-hide-descendants',
}}
touchableDoneProps={{
accessibilityRole: CONST.ROLE.BUTTON,
}}
touchableWrapperProps={{
accessible: true,
accessibilityRole: CONST.ROLE.COMBOBOX,
accessibilityLabel,
accessibilityState: {disabled: isDisabled, expanded: isHighlighted},
}}
pickerProps={{
ref: picker,
tabIndex: pickerTabIndex,
Expand Down
Loading