fix: resolve npm install, lint, and reanimated test failures#37
Merged
Conversation
npm resolves react-dom@19 transitively via styled-components, which conflicts with the pinned react@18.2.0. Pinning react-dom@18.2.0 fixes the ERESOLVE error.
eslint-plugin-sonarjs@3.0.7 removed this rule but @exodus/eslint-config-exodus@1.7.1 still references it.
react-native-reanimated@3.19.5 mock no longer flattens style arrays. Update assertions to expect the array format that shakl produces, which is valid for React Native's style prop.
This repo uses yarn, not npm.
alexondrius
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-dom@18.2.0to devDependencies to fixnpm installERESOLVE conflict (react-dom@19 pulled transitively via styled-components)sonarjs/no-one-iteration-loopin eslint config — rule removed in sonarjs@3.0.7 but still referenced by @exodus/eslint-config-exodus@1.7.1Test plan
npm installsucceedsnpm run lintpassesnpm test— all 52 tests pass