Skip to content

Fix PHP 8.0 Fatal Errors when there are no forms available #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bolorino wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP 8.0 Fatal Errors when there are no forms available #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/partials/menu/manage-forms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<!-- TABLE BODY -->
<tbody>
<?php
if ( count( $all_forms ) > 0 ) {
if ( $all_forms && count( $all_forms ) > 0 ) {
$i = 1;
foreach( $all_forms as $id => $form ) {
?>
Expand Down
15 changes: 12 additions & 3 deletions includes/class-yikes-inc-easy-mailchimp-extender-option-forms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,14 @@ public function get_form( $form_id ) {
* Get the IDs of all registered forms.
*
* @author Jeremy Pry
* @return array All form IDs.
* @return array|bool All form IDs.
*/
public function get_form_ids() {
return array_keys( $this->get_all_forms() );
if ( is_array( $this->get_all_forms() ) ) {
return array_keys( $this->get_all_forms() );
}

return false;
}

/**
Expand Down Expand Up @@ -77,7 +81,12 @@ public function create_form( $form_data ) {

// Grab our existing IDs and determine what the next one should be.
$all_ids = $this->get_form_ids();
$last_id = end( $all_ids );
$last_id = 0;

if ( is_array( $all_ids ) ) {
$last_id = end( $all_ids );
}

$new_id = false === $last_id ? 1 : $last_id + 1;
$form_data['id'] = $new_id;

Expand Down