fix: Add buffer polyfill with base64url support#153
Merged
Conversation
Contributor
|
Thanks @felipecsl for quick reaction. I confirm that it solves the buffer error that I previously encountered! |
maya-the-mango
approved these changes
Dec 2, 2024
leoromanovsky
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: FF-3645
Motivation and Context
Add
bufferfork polyfill with support forbase64urlencoding.Code is here https://github.com/Eppo-exp/buffer/tree/add-base64url-support
Source: feross/buffer#314 (once this is merged, we can revert back to the main buffer repo)
Description
Make sure we polyfill
bufferfor browser environment and it has support forbase64url.Thanks @maya-the-mango for reporting and helping with debugging
How has this been tested?
"@eppo/js-client-sdk": "^3.8.0",called
initand verified no errors thrown