Skip to content

make_zero(!) bugfixes and improved tests #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wsmoses merged 6 commits into from
Nov 28, 2024
+912 −130
Merged

make_zero(!) bugfixes and improved tests #1961

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac1a8df
Fix make_zero(!) bugs
danielwe Oct 3, 2024
7838c29
Add make_zero(!) tests
danielwe Oct 3, 2024
48a6e6f
Fix more make_zero(!) bugs and add more tests
danielwe Oct 22, 2024
0d00224
Improve make_zero! error message
danielwe Nov 27, 2024
cc88240
Simplify likely dead branch
danielwe Nov 28, 2024
636b025
Reinstate single-arg StaticArrays methods
danielwe Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions ext/EnzymeStaticArraysExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,37 @@ end
end
end

@inline function Enzyme.EnzymeCore.make_zero(x::FT)::FT where {FT<:SArray}
Comment thread
danielwe marked this conversation as resolved.
return Base.zero(x)
@inline function Enzyme.EnzymeCore.make_zero(
::Type{FT}, seen::IdDict, prev::FT, ::Val{copy_if_inactive}
) where {S,T<:Union{AbstractFloat,Complex{<:AbstractFloat}},FT<:SArray{S,T},copy_if_inactive}
return Base.zero(prev)::FT
end
@inline function Enzyme.EnzymeCore.make_zero(x::FT)::FT where {FT<:MArray}
return Base.zero(x)
@inline function Enzyme.EnzymeCore.make_zero(
::Type{FT}, seen::IdDict, prev::FT, ::Val{copy_if_inactive}
) where {S,T<:Union{AbstractFloat,Complex{<:AbstractFloat}},FT<:MArray{S,T},copy_if_inactive}
if haskey(seen, prev)
return seen[prev]
end
new = Base.zero(prev)::FT
seen[prev] = new
return new
end
@inline function Enzyme.EnzymeCore.make_zero!(
prev::FT, seen
) where {S,T<:Union{AbstractFloat,Complex{<:AbstractFloat}},FT<:MArray{S,T}}
if !isnothing(seen)
if prev in seen
return nothing
end
push!(seen, prev)
end
fill!(prev, zero(T))
return nothing
end
@inline function Enzyme.EnzymeCore.make_zero!(
prev::FT
) where {S,T<:Union{AbstractFloat,Complex{<:AbstractFloat}},FT<:MArray{S,T}}
return Enzyme.EnzymeCore.make_zero!(prev, nothing)
end

end
Loading