Initialize using gravity vectors to exclude the influence of the orientation during initialization#79
Open
Zhaosn wants to merge 5 commits into
Open
Initialize using gravity vectors to exclude the influence of the orientation during initialization#79Zhaosn wants to merge 5 commits into
Zhaosn wants to merge 5 commits into
Conversation
…eters required that the Z-axis be exactly parallel to and upward of the direction of gravity, but now a normalized gravity vector is used. This algorithm for obtaining the normalized vector could perhaps be replaced by "Fast Inverse Square Root".
Unit vectors with offsets close to zero are literally monsters!
…ode unchanged and keep the z-axis calibrated upwards, just make sure the z-axis was calibrated upwards. Now all directions can be just as bad, and the calibration error is related to epsilon
Author
|
Unfortunately, the bugs in this code don't always recur, causing me to repeat changes, and I apologize for the frequent interruptions. Lines 3438 to 3443 in fbb3de4 |
If the acceleration reading is [0 0 0] at the beginning, it causes the unit vector to return [nan nan nan nan], which causes the ITerm always be nan, leading to unconvergence Signed-off-by: Zhaosn <35885918+Zhaosn@users.noreply.github.com>
Signed-off-by: Zhaosn <35885918+Zhaosn@users.noreply.github.com>
Member
|
Hi @Zhaosn Thank you for the contribution. Could you please share more details about the bug you are mentioning? Additionally, is there any setup you can share with us to test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method of subtracting gravity when calibrating accelerometers required that the Z-axis is upward, but now a gravity vector is used.
Now, when I initialize the module with the Z-axis not facing up, the first few returns will be around 0 and then jump to the actual value, instead of the initialized position as ypr=0 (which is what I thought it would be before). And it doesn't have this problem: #77
It's worth to note that my tests show it's maybe better to keep the code unchanged and keep the z-axis calibrated upwards, just make sure the z-axis was calibrated upwards. Now all directions can be just as bad, and the calibration error is related to epsilon.
(fix #78)