Skip to content

Remove builtin tokens #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peachbits wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Remove builtin tokens #710

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a475723
Describe how customTokenTemplate should be used
peachbits Jan 8, 2026
8d51b03
Make sure enabled tokens exist in customTokens object
peachbits Jan 9, 2026
88730ae
Use builtinTokens.json over accountState.builtinTokens for legacy fun…
peachbits Jan 9, 2026
46dc32c
Make currencyCode access safer
peachbits Feb 19, 2026
36a0d59
Remove builtinTokens
peachbits Jan 12, 2026
98c9a50
Add isUserCreated to EdgeToken
peachbits Jan 14, 2026
7613aff
Add addCustomTokens to CurrencyConfig
peachbits Feb 19, 2026
7680874
fixup! Describe how customTokenTemplate should be used
peachbits Feb 27, 2026
1b2fe7b
Revert "Make currencyCode access safer"
peachbits Feb 27, 2026
3f9b5f3
Remove `balances`
peachbits Feb 27, 2026
16784c4
fixup! Use builtinTokens.json over accountState.builtinTokens for leg…
peachbits Feb 27, 2026
568b357
fixup! Remove builtinTokens
peachbits Feb 27, 2026
f3cda44
fixup! Remove builtinTokens
peachbits Feb 27, 2026
8fbb8f0
fixup! Make sure enabled tokens exist in customTokens object
peachbits Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ export interface EdgeCurrencyInfo {
canImportKeys?: boolean // Defaults to false
canReplaceByFee?: boolean // Defaults to false
customFeeTemplate?: EdgeObjectTemplate // Indicates custom fee support
customTokenTemplate?: EdgeObjectTemplate // Indicates custom token support
customTokenTemplate?: EdgeObjectTemplate // An empty array indicates token support. A filled array indicates custom token support.

@swansontec swansontec Feb 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this. It's too subtle, and makes the code hard to understand. Let's add an explicit hasTokens?: boolean instead, and leave customTokenTemplate just for custom token support.

requiredConfirmations?: number // Block confirmations required for a tx

/** EVM chain id */
Expand Down