Draft
Conversation
Contributor
Author
|
Notes:
|
Contributor
Author
|
FYI, probably gonna hold off and refactor this after #164 gets done. |
Contributor
Author
|
I believe I found the root cause to the issue with this PR. However, from what I understand, a deletion request is also sent to the leader node. I believe this request specifically is what's causing the response to get hung up. This causes a deadlock because in SugarDB.evictKeysWithExpiredTTL() we have to engage the storeLock as well as the keysWithExpiry lock. BUT these two locks are engaged in the HandlerFuncParams.DeleteKey() function. This seems to be a catch 22, since these locks are needed in both places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses #151.