feat: add params to requestPin#662
Merged
Merged
Conversation
| CarrierAccountId = "ca_123", | ||
| }; | ||
|
|
||
| FedExRequestPinResponse response = await Client.FedExRegistration.RequestPin("123456789", "SMS", parameters); |
There was a problem hiding this comment.
Not sure if it matters but phone numbers are 10 digits not 9
Member
Author
There was a problem hiding this comment.
The first param is for a FedEx account number, though next to the 2nd param I can see the confusion!
sroomberg-ep
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
paramstorequestPinensuring users can passeasypost_detailsto the call.Testing
Updated test to accept new param.
Pull Request Type
Please select the option(s) that are relevant to this PR.