Code update for pandas 3#226
Conversation
|
tested with pandas 3.0.0 and 2.3.3 |
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @mutricyl for the PR, appreciate it!
We need testing to ensure it still works with pandas 2 and that pandas 3 works as expected.
Please add a new tox environment specific for pandas2 in tox.ini and call that from the test workflow.
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
I see you added a new tox env, thanks!
However we need to reference it in test.yml otherwise it won't run in CI.
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a lot @mutricyl, this looks great!
I will prepare a new release shortly once we merge it.
|
I am kind of noob with GH workflows and tox. So I was checking on my side. looks like you are more confident than me 😄 |
|
Yeah all looks correct to me, well done. 👍 |
2 participants
resolves #225