[ASIM] - Change PluginInfo and add some type annotation#145
Merged
Conversation
87e3ae0 to
873477a
Compare
nicoddemus
requested changes
Jun 5, 2025
Member
There was a problem hiding this comment.
Nice cleanup!
However, we should not add "sdk_version" explicitly like this -- SDK is something used by ALFAsim but is not necessarily true for all users of hookman.
We should add a way to add generic requirements, without naming them, for example I can pass {"a": ">=1.2.0", "b": ">=3.0.0"}.
While python_version makes sense, I think it is simpler to just work with a generic requirements: dict[str, str] instead.
For alfasim, we will use hookman passing the requirements explicitly, for example: {"alfasim_sdk": ">=1.0", "python": ">=3.10,<3.11"}.
cauebs
reviewed
Jun 5, 2025
6d65a3a to
351db7c
Compare
cauebs
approved these changes
Jun 5, 2025
a149acf to
a3f397b
Compare
Update PluginInfo to accept a new optional requirements dict.
318932c to
9f06ad5
Compare
for more information, see https://pre-commit.ci
nicoddemus
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some new property
requirementwhich includes thesdk_version, python_versionfor plugins and add some type annotations.