-
Notifications
You must be signed in to change notification settings - Fork 152
Radiation budget: labelling plots with alias #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NParsonsMO
wants to merge
12
commits into
main
Choose a base branch
from
4291-amend-radiation-budget-to-use-alias
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5885188
Amending plot f-strings
NParsonsMO e70fa29
Retry, in the right folder?!
NParsonsMO 8ebc7e7
Switch to double quotes
NParsonsMO 0595c1a
accidental rename
NParsonsMO 04cc201
Accepting suggestion
NParsonsMO 03c1812
Removing `model_dataset` from `plot_data` function
NParsonsMO d35f17c
Alphabetising and adding parameter description
NParsonsMO b7e7b8e
Adding aliases equal to `dataset`s
NParsonsMO 1feb6ba
Adding in-code comment about model period assumption
NParsonsMO e172b65
Adding alias to documentation
NParsonsMO 650a6c1
Merge branch 'main' into 4291-amend-radiation-budget-to-use-alias
NParsonsMO 19507b5
Merge branch 'main' into 4291-amend-radiation-budget-to-use-alias
NParsonsMO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, we wanted to affect
aliasvia CMEW by addingaliasto a givendatasetin the recipe. I'm debating whether we should, now that you have shared before and after images showing the introduction of thealias, specify thealiasin thedatasetso that the images are the same as before? π€There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, and this has nothing to do with what you have done, but
group[0]is a bit dubious. An assumption has been made that thestart_yearandend_yearfrom the first variable in the list (for a given dataset) is the same as all the others. This might be a reasonable assumption to make! We should either add a comment stating this assumption, or do a check to ensure that these values are consistent across variables (they really should be, and I don't know what we would do if they weren't!).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b7e7b8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done within the function:
1feb6ba
Do you want it documented elsewhere as well?