testing; ccs_config coarse resolution BHIST (for DART) - #285
Conversation
Changes are needed in multiple components: cesm, ccs_config, cime, cmeps, mom/MOM6.
The branches are labeled with DART_lowres_{component}.
modelgrid_aliases_nuopc.xml
Added coarse resolution ne3pg3_ne3pg3_t232
ocn grid is made coarse by settings in testmod mom/tx10deg
Deleted redundant copy of ne30pg3_t232
|
@alperaltuntas - since it sounds like @kdraeder adapted these changes from some things you did, would you be able to review this? |
|
I've imported the changes to the most recent CESM tag; cesm3_0_alpha09a. |
|
@kdraeder Have you made any changes to the resolution definition in your latest sandbox. If not, then I think this PR can be merged as is. |
For better or worse, the changes proposed based on the earlier CESM were used in the recent CESM. |
|
@alperaltuntas I believe that I fixed the mistakes, but the PR still says Changes requested. |
|
@kdraeder This PR looks good to me. One heads-up, though: we're pivoting to the new Workhorse ocean grid, tx2_3v3. You may want to add a resolution with that grid as well. |
|
Thanks, @alperaltuntas . @kdraeder - Based on @alperaltuntas 's comment, would it make sense to use that newer grid in your test so you're using the standard one that others will be using? If you prefer to stick with this one, that's fine, too. Either way, as I looked at this PR a bit more, I also have two other requests: (1) It looks like this new grid is a bit out of place in the file. It appears in the section for ne3pg2 grids. Can you please move the new block to the section with other ne3pg3 grids (with comment, "spectral element grids with 3x3 FVM physics grid"), if you agree? (2) I appreciate your adding a comment describing the purpose of the grid, but I feel it would be more clear if it said something like, "low-res atm & ocn grid useful for B compset testing, e.g., for DART". |
@alperaltuntas Thanks for this tip! |
|
@billsacks I agree with (1) and (2). |
|
@alperaltuntas Let me know whether this should be new issue somewhere else. |
|
@kdraeder Yes, you can still set up a coarse-resolution test case using the mom-tx10deg testmods. Note that we're in the process of adding a proper 2-degree grid that will be officially supported for users, unlike the currently available testmods. As part of that work, I plan to remove the mom-tx3deg testmods at some point, but mom-tx10deg will remain available. |
|
@billsacks @alperaltuntas I'm glad to hear that the 10 degree will be available; it's very helpful for testing the large ensembles which DART needs to use. |
|
@billsacks @alperaltuntas |
|
I'm fine with this. I've kind of lost track of the details here, though, so @kdraeder and @alperaltuntas please comment on whether you feel this is ready to merge at this point. |
|
It's just an additional conditional print statement, and it works when it should, |
|
@alperaltuntas and @billsacks since this grid is intended for a B compset test. Shouldn't the model grid alias be ne3pg3_t232? When I first saw ne3pg3_ne3pg3_t232 I thought it was a typo and was suppose to be ne3pg3_ne3pg3_mt232. Then I got confused when I saw that it was for a B compset test. |
@kdraeder - I think you're referring to a different PR. This one adds a new grid.
Very good point, @fischer-ncar . @kdraeder and @alperaltuntas can you please comment on this? |
|
I haven't seen a description of an alias naming convention for grids, [Sorry about the errant comment; too many related PRs] |
Background
This is one of 5 related (small) PRs are required to implement coarse-resolution BHIST MCC and ERI tests:
I will include their PR numbers after they've all been assigned.
They have been developed under branch names DART_lowres_{component},
which were branched from a CESM clone copied from @alperaltuntas ;
/glade/work/raeder/Models/cesm3_0_alpha08d_mar13
which implements a coarse-resolution mom via the new testmod mom/tx10deg.
Fixes Issue:
I did not open a ccs_config issue because the work started in other components and spread to ccs_config.
I'll open one if that helps the workflow.
Otherwise, this PR contributes to fixing encompassing issue ESMCI/cime#4933 and background issue cam ESCOMP/CAM#1482 (closed).
The specific fixes are described in the commit messages.
User interface changes?
Yes (sometimes). In order to run tests of certain sizes parameters in the new testmod
{CESM}/cime_config/testmods_dirs/allactive/DART_BHIST_lowres
must be set according to instructions in .../README_layout
Tests
The changes have passed tests: