fix: エージェントコマース用 scope の同意画面表示を翻訳 - #196
Open
nanasess wants to merge 1 commit into
Open
Conversation
権限移譲確認画面は `api.admin.oauth.scope.<scope>.description` で 要求 scope を表示するが、 `acp:*` / `ucp:*` の翻訳が未定義のため 翻訳キー (例: api.admin.oauth.scope.ucp:identity.description) が そのまま表示されていた。 `scopes.available` の全 scope 分の説明を ja / en に追加し、 同期漏れを検知するテストを追加する。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resource/template/admin/OAuth/authorization.twig) でucp:identityなどの scope が翻訳されず、翻訳キーapi.admin.oauth.scope.ucp:identity.descriptionがそのまま表示されていた問題を修正しますResource/config/services.yamlのscopes.availableに追加されたacp:*/ucp:*の description が翻訳ファイルに未定義だったことです (read/write/mcp:*のみ定義済みでした)ucp:identity単体ではなくacp:*/ucp:*の 6 scope すべてが同じ状態だったため、まとめて追加していますChanges
Resource/locale/messages.ja.yaml/Resource/locale/messages.en.yamlscope.acp:checkout.descriptionscope.acp:catalog.descriptionscope.ucp:checkout.descriptionscope.ucp:cart.descriptionscope.ucp:catalog.descriptionscope.ucp:identity.descriptionTests/Resource/ScopeTranslationTest.php(新規)scopes.availableの全 scope について ja / en のscope.<scope>.descriptionが定義済みであることを検証し、scope 追加時の翻訳漏れを検知しますTest plan
Tests/Resource/ScopeTranslationTest.phpが ja / en 両方で pass することscope=ucp:identityを含む認可リクエストで同意画面に翻訳済みの文言が表示されること (翻訳キーがそのまま出ないこと)Tests/Web/Admin/OAuth2Bundle/AuthorizationControllerTest.php(read / write の表示検証) が引き続き pass すること🤖 Generated with Claude Code