-
Notifications
You must be signed in to change notification settings - Fork 718
docs(skills): Skill の欠落を補完(実害の出た落とし穴・アセットビルド規約の新設・検証手順) #7008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ttokoro20240902
wants to merge
9
commits into
4.4
Choose a base branch
from
docs/skill-known-pitfalls-followup
base: 4.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a06a18e
docs(skills): 実害の出た落とし穴を各 Skill に反映(認可の在り処・InputBag・トランザクション境界ほか)
ttokoro20240902 2d1b9b4
docs(skills): アセットビルド規約 eccube-asset を追加
ttokoro20240902 3f07222
docs(skills): 検証手順が無かった 7 Skill に「実行・確認方法」を追加する
ttokoro20240902 7806e38
docs(skills): CodeRabbit 指摘を反映(匿名許可ルートの除外・カラム追加の例外)
ttokoro20240902 b4a8fcb
Merge remote-tracking branch 'origin/4.4' into docs/skill-known-pitfa…
ttokoro20240902 a834357
docs(skills): eccube-asset を本 PR から分離し AGENTS.md の索引漏れを補う
ttokoro20240902 679e9d3
docs(skills): 実行例をコピペ可能にし PHPStan の実行範囲を段階化
ttokoro20240902 70ad800
docs(skills): 実害の出た落とし穴を 7 件追記(すべて 4.4 の実コードで裏取り)
ttokoro20240902 37f27fd
docs(skills): debug:container の例を FQCN にする(部分一致は対話選択になる)
ttokoro20240902 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.