-
Notifications
You must be signed in to change notification settings - Fork 718
feat: 店舗設定に構造化データ拡張項目を追加 (sameAs/foundingDate 等) (#6147) #6957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ttokoro20240902
wants to merge
9
commits into
4.4
Choose a base branch
from
feature/issue-6147-baseinfo-schema
base: 4.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b9d9b26
feat(schema): 店舗設定に構造化データ拡張項目を追加(sameAs/foundingDate 等)
ttokoro20240902 4e3a5c0
feat(schema): 営業時間(OpeningHoursSpecification)を店舗設定に追加
ttokoro20240902 4e97130
feat(schema): 構造化データ拡張項目のバリデーション強化とテスト追加
ttokoro20240902 c4e64cb
fix(schema): CodeRabbit指摘対応(number_of_employees上限・単純カラムmigration削除)
ttokoro20240902 026a317
Merge branch '4.4' into feature/issue-6147-baseinfo-schema
ttokoro20240902 41bbff5
Merge branch '4.4' into feature/issue-6147-baseinfo-schema
ttokoro20240902 61e8822
Merge branch '4.4' into feature/issue-6147-baseinfo-schema
ttokoro20240902 97f3925
fix: CodeRabbit 指摘への対応(営業時間の重複エラー位置・テストの型宣言・E2Eの後始末)
ttokoro20240902 f758d7e
Merge branch '4.4' into feature/issue-6147-baseinfo-schema
ttokoro20240902 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /* | ||
| * This file is part of EC-CUBE | ||
| * | ||
| * Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved. | ||
| * | ||
| * http://www.ec-cube.co.jp/ | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace DoctrineMigrations; | ||
|
|
||
| use Doctrine\DBAL\Schema\Schema; | ||
| use Doctrine\DBAL\Types\Types; | ||
| use Doctrine\Migrations\AbstractMigration; | ||
|
|
||
| /** | ||
| * 営業時間(構造化データ schema.org OpeningHoursSpecification)用の dtb_opening_hours を作成する. | ||
| */ | ||
| final class Version20260722010000 extends AbstractMigration | ||
| { | ||
| public const NAME = 'dtb_opening_hours'; | ||
|
|
||
| public function up(Schema $schema): void | ||
| { | ||
| if ($schema->hasTable(self::NAME)) { | ||
| return; | ||
| } | ||
|
|
||
| $table = $schema->createTable(self::NAME); | ||
| $table->addColumn('id', Types::INTEGER, ['autoincrement' => true, 'unsigned' => true]); | ||
| $table->addColumn('base_info_id', Types::INTEGER, ['unsigned' => true, 'notnull' => false]); | ||
| $table->addColumn('day_of_week', Types::SIMPLE_ARRAY, ['notnull' => false]); | ||
| $table->addColumn('opens', Types::TIME_MUTABLE, ['notnull' => false]); | ||
| $table->addColumn('closes', Types::TIME_MUTABLE, ['notnull' => false]); | ||
| $table->addColumn('sort_no', Types::INTEGER, ['default' => 0]); | ||
| $table->addColumn('discriminator_type', Types::STRING, ['length' => 255]); | ||
| $table->setPrimaryKey(['id']); | ||
| $table->addIndex(['base_info_id'], 'dtb_opening_hours_base_info_id_idx'); | ||
| $table->addForeignKeyConstraint('dtb_base_info', ['base_info_id'], ['id'], [], 'fk_opening_hours_base_info'); | ||
| } | ||
|
|
||
| public function down(Schema $schema): void | ||
| { | ||
| if (!$schema->hasTable(self::NAME)) { | ||
| return; | ||
| } | ||
|
|
||
| $schema->dropTable(self::NAME); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.