recipes: remove S = ${UNPACKDIR}/git for Whinlatter compliance#279
Draft
ajlennon wants to merge 1 commit into
Draft
recipes: remove S = ${UNPACKDIR}/git for Whinlatter compliance#279ajlennon wants to merge 1 commit into
ajlennon wants to merge 1 commit into
Conversation
Yocto 5.3 (whinlatter) errors when recipes explicitly set
S = "${UNPACKDIR}/git" because oe-core bitbake.conf now sets S
to match BB_GIT_DEFAULT_DESTSUFFIX (BP) automatically.
This fixes mono-native-6.12.0.206 do_unpack failure in CI.
Co-authored-by: Alex Lennon <ajlennon@dynamicdevices.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI build failure in run 28430587738.
Problem
The whinlatter build failed during
mono-native-6.12.0.206:do_unpackwith:Yocto 5.3 (whinlatter) changed the git fetcher to unpack into
BB_GIT_DEFAULT_DESTSUFFIX(set to${BP}in oe-core), which matches the defaultSfrombitbake.conf. ExplicitS = "${UNPACKDIR}/git"assignments are now rejected.Fix
Remove all
S = "${UNPACKDIR}/git"lines from git-based recipes across the layer (10 files):recipes-mono/mono/mono-6.12.0.206.inc(the immediate CI failure)recipes-mono/mono/mono-git.increcipes-mono/msbuild/msbuild_16.10.1.bbrecipes-mono/taglib-sharp/taglib-sharp.increcipes-mono/mono-xsp/mono-xsp_git.bbrecipes-mono/mono-addins/mono-addins-xbuild.increcipes-mono/mono-addins/mono-addins.increcipes-mono/mono-upnp/mono-upnp.increcipes-mono/gtk-sharp/gtk-sharp3_2.99.4.bbrecipes-mono/libgdiplus/libgdiplus-common.incPer the Yocto 5.3 migration guide, these assignments should simply be deleted — no replacement is needed for recipes where the source root is the git checkout itself.