Improve the EH transfer function by updating the zd and sh_d fits#118
Open
MinhMPA wants to merge 5 commits intoDifferentiableUniverseInitiative:masterfrom
Open
Conversation
Member
|
@claude can you review this PR and add a test of the new functions? |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Author
|
@EiffL Not sure what the problem with the Claude review is. But since I started this PR, I have moved away from the fit in this PR to another one more well-behaved and much closer to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sound horizon in EH 1998 fit is only accurate up to 2%. This is easily noticeable when one considers BAO quantities like
DA/sh_d. This (in)accuracy further affects the transfer function.The issue ultimately boils down to the fit for redshift at drag epoch,
z_dgiven in EH 1998. So one can either improve on that, or directly on the sound horizon at drag epoch,zh_d. There are plenty literature on this, here I picked thez_dandsh_dfits from arXiv:2106.00428, which should providesh_dat sub-percent accuracy (within LCDM).