Allow 1d and 2d normal fields in distributed mode#54
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the distributed array handling in jaxpm/distributed.py to support 1D and 2D arrays in distributed mode, particularly for HEALPix spherical arrays. The changes make sharding logic more flexible and robust when working with arrays of varying dimensionality.
Changes:
- Refactored
get_local_shapeto dynamically map axis names to device sizes and handle arrays with fewer dimensions than the sharding specification - Added
get_sharding_for_shapehelper function to trim sharding specs to match array dimensionality - Updated
normal_fieldto use the new trimming logic before applying sharding
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the handling of distributed array shapes and sharding specifications in
jaxpm/distributed.py. The main focus is on making sharding logic more robust and flexible, especially when working with arrays of varying dimensionality. The most important changes are grouped below:Enhancements to sharding and shape handling:
get_local_shapeto more accurately compute local shapes by mapping axis names to device sizes and handling cases where the mesh or sharding spec does not match the array dimensionality.get_sharding_for_shape, a new helper function that trims the sharding specification to match the dimensionality of the target array, ensuring correct sharding for lower-dimensional arrays.normal_fieldto callget_sharding_for_shapebefore using sharding, ensuring the sharding spec matches the array shape.API and import improvements:
NamedShardingfromjax.sharding, supporting the new sharding logic.