Skip to content

Add MbsDetector, remove unneeded EnergySource logic#2071

Open
oliwenmandiamond wants to merge 42 commits into
mainfrom
mbs_detector
Open

Add MbsDetector, remove unneeded EnergySource logic#2071
oliwenmandiamond wants to merge 42 commits into
mainfrom
mbs_detector

Conversation

@oliwenmandiamond
Copy link
Copy Markdown
Contributor

@oliwenmandiamond oliwenmandiamond commented May 22, 2026

Fixes #2070

Instructions to reviewer on how to test:

  1. Check tests pass
  2. Implementation makes sense

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (f787f83) to head (153fde4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
- Coverage   99.14%   99.14%   -0.01%     
==========================================
  Files         341      342       +1     
  Lines       13287    13281       -6     
==========================================
- Hits        13173    13167       -6     
  Misses        114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from add_mbs_analyser to main May 26, 2026 15:07
@oliwenmandiamond oliwenmandiamond marked this pull request as ready for review May 26, 2026 15:34
@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner May 26, 2026 15:34
@oliwenmandiamond oliwenmandiamond requested a review from Villtord May 26, 2026 15:34
@oliwenmandiamond oliwenmandiamond self-assigned this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Mbs detector

1 participant