Skip to content

allow internal (freerun) mode on tetramms #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RJCD-Diamond wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

allow internal (freerun) mode on tetramms #1736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/dodal/devices/tetramm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,11 @@ class TetrammDriver(NDArrayBaseIO):
class TetrammController(DetectorController):
"""Controller for a TetrAMM current monitor"""

_supported_trigger_types = {
_trigger_types = {
DetectorTrigger.EDGE_TRIGGER: TetrammTrigger.EXT_TRIGGER,
DetectorTrigger.CONSTANT_GATE: TetrammTrigger.EXT_TRIGGER,
DetectorTrigger.VARIABLE_GATE: TetrammTrigger.EXT_TRIGGER,
DetectorTrigger.INTERNAL: TetrammTrigger.FREE_RUN,
}
""""On the TetrAMM ASCII mode requires a minimum value of ValuesPerRead of 500,
[...] binary mode the minimum value of ValuesPerRead is 5."
Expand All @@ -100,10 +101,10 @@ def get_deadtime(self, exposure: float | None) -> float:
return 2 / self._base_sample_rate

async def prepare(self, trigger_info: TriggerInfo) -> None:
if trigger_info.trigger not in self._supported_trigger_types:
if trigger_info.trigger not in self._trigger_types:
raise TypeError(
f"{self.__class__.__name__} only supports the following trigger "
f"types: {[k.name for k in self._supported_trigger_types]} but was asked to "
f"types: {[k.name for k in self._trigger_types]} but was asked to "
f"use {trigger_info.trigger}"
)
if trigger_info.livetime is None:
Expand All @@ -116,9 +117,7 @@ async def prepare(self, trigger_info: TriggerInfo) -> None:
await self.disarm()

# trigger mode must be set first and on its own!
await self.driver.trigger_mode.set(
self._supported_trigger_types[trigger_info.trigger]
)
await self.driver.trigger_mode.set(self._trigger_types[trigger_info.trigger])

await asyncio.gather(
self.set_exposure(trigger_info.livetime),
Expand Down
Loading